Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1407063011: Revert of Fix mixed samples stencil clip (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
bsalomon, rmistry
CC:
reviews_skia.org, nv_mark, Kimmo Kinnunen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix mixed samples stencil clip (patchset #5 id:80001 of https://codereview.chromium.org/1431593006/ ) Reason for revert: Co-centered sample locations are not needed to do stencil clip with mixed samples. Original issue's description: > Fix mixed samples stencil clip > > Fixes rendering bugs and nondeterminism in gm. > > Before, mixed samples stencil clip would try to infer whether the draw > wanted co-centered sample locations from within GrGLGpu, which caused > various errors. This change reworks it so the draw itself can request > the co-centered sample locations when it knows it will need them. > > Also reduces framebuffer binds by moving the code that enables > GL_FRAMEBUFFER_PROGRAMMABLE_SAMPLE_LOCATIONS into flushRenderTarget. > > Committed: https://skia.googlesource.com/skia/+/14184d5567b58085b6d8a6375796d405056f7f73 TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d472792a72c0c433a205d42a73e0b77d65f8d76f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -111 lines) Patch
M include/gpu/GrCaps.h View 4 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrCaps.cpp View 4 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +1 line, -11 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +2 lines, -16 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +16 lines, -10 lines 0 comments Download
M src/gpu/GrPipeline.h View 4 chunks +1 line, -4 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 4 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 5 chunks +41 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 3 chunks +21 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (3 generated)
Chris Dalton
Created Revert of Fix mixed samples stencil clip
5 years, 1 month ago (2015-11-10 17:58:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 17:58:50 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-10 17:58:51 UTC) #3
Chris Dalton
5 years, 1 month ago (2015-11-10 17:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 18:01:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 18:31:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 19:01:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 19:31:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 20:00:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 20:30:53 UTC) #10
rmistry
lgtm
5 years, 1 month ago (2015-11-10 20:48:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407063011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407063011/1
5 years, 1 month ago (2015-11-10 20:48:54 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 20:49:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d472792a72c0c433a205d42a73e0b77d65f8d76f

Powered by Google App Engine
This is Rietveld 408576698