Refactor Future constructors.

Refactor Future constructors.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21517

[floitsch, 2013-04-13 15:51:41]

I'm willing to discuss the "Future.sync" name (although I'm find it not too
bad), but the other names look pretty good to me.

[Sean Eagan, 2013-04-13 18:35:00]

On 2013/04/13 15:51:41, floitsch wrote:
> I'm willing to discuss the "Future.sync" name (although I'm find it not too
> bad), but the other names look pretty good to me.

On 2013/04/13 15:51:41, floitsch wrote:
> I'm willing to discuss the "Future.sync" name (although I'm find it not too
> bad), but the other names look pretty good to me.

Suggestions:

Future -> Future.compute
Future.sync -> Future.computeSync
Future.value -> Future.complete
Future.error -> Future.fail
Completer.completeException -> Completer.fail

[Anders Johnsen, 2013-04-15 08:59:06]

LGTM

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:143: * A future that completes with an error in the
next event-loop iteration.
Write it's the same as new Future(() => throw new AsyncError(error,
stackTrace));?

https://codereview.chromium.org/14070010/diff/1/tests/lib/async/future_constr...
File tests/lib/async/future_constructor_test.dart (right):

https://codereview.chromium.org/14070010/diff/1/tests/lib/async/future_constr...
tests/lib/async/future_constructor_test.dart:27: Future err2 = new
Future.error(new AsyncError("AsyncError"))..catchError((_){});
Long line.

[Lasse Reichstein Nielsen, 2013-04-15 10:27:45]

lgtm

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:104: new _ThenFuture<dynamic, T>((_) =>
computation());
I'd prefer using _FutureImpl directly instead of _ThenFuture, but I can see this
is shorter.

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:123: factory Future.sync(computation()) {
I prefer Future.of.
The "sync" name (apart from being an abbreviation) isn't obvious. Nor is "of",
on the other hand, it's so bland it can mean anything.
So I guess it's down to: I don't like "sync"!

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:143: * A future that completes with an error in the
next event-loop iteration.
I hope not. You should never throw an AsyncError (but I guess we have accepted
it in places as a kind of rethrow).

[nweiz, 2013-04-15 19:53:39]

pub and pkg changes lgtm

[floitsch, 2013-04-15 20:30:11]

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:104: new _ThenFuture<dynamic, T>((_) =>
computation());
On 2013/04/15 10:27:46, Lasse Reichstein Nielsen wrote:
> I'd prefer using _FutureImpl directly instead of _ThenFuture, but I can see
this
> is shorter.

Falls under "optimizations for later" category.

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:123: factory Future.sync(computation()) {
On 2013/04/15 10:27:46, Lasse Reichstein Nielsen wrote:
> I prefer Future.of.
> The "sync" name (apart from being an abbreviation) isn't obvious. Nor is "of",
> on the other hand, it's so bland it can mean anything.
> So I guess it's down to: I don't like "sync"!

A lot of users got this confused and thought that "of" would by asynchronous. At
least "sync" makes it really clear.

https://codereview.chromium.org/14070010/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:143: * A future that completes with an error in the
next event-loop iteration.
On 2013/04/15 08:59:06, Anders Johnsen wrote:
> Write it's the same as new Future(() => throw new AsyncError(error,
> stackTrace));?

AsyncError is gone.

[floitsch, 2013-04-15 21:20:50]

https://codereview.chromium.org/14070010/diff/1/tests/lib/async/future_constr...
File tests/lib/async/future_constructor_test.dart (right):

https://codereview.chromium.org/14070010/diff/1/tests/lib/async/future_constr...
tests/lib/async/future_constructor_test.dart:27: Future err2 = new
Future.error(new AsyncError("AsyncError"))..catchError((_){});
On 2013/04/15 08:59:06, Anders Johnsen wrote:
> Long line.

Gone with AsyncError removal.

[floitsch, 2013-04-15 21:25:57]

Committed patchset #3 manually as r21517 (presubmit successful).