Refactor Future constructors.

pkg/oauth2/test/client_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library client_test;
 
 import 'dart:async';
 import 'dart:io';
 import 'dart:json' as JSON;
 import 'dart:uri';
@@ skipping 39 matching lines @@
         "request", () {
       var expiration = new DateTime.now().subtract(new Duration(hours: 1));
       var credentials = new oauth2.Credentials(
           'access token', 'refresh token', tokenEndpoint, [], expiration);
       var client = new oauth2.Client('identifier', 'secret', credentials,
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('POST'));
         expect(request.url.toString(), equals(tokenEndpoint.toString()));
-        return new Future.immediate(new http.Response(JSON.stringify({
+        return new Future.value(new http.Response(JSON.stringify({
           'access_token': 'new access token',
           'token_type': 'bearer'
         }), 200, headers: {'content-type': 'application/json'}));
       });
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('GET'));
         expect(request.url.toString(), equals(requestUri.toString()));
         expect(request.headers['authorization'],
             equals('Bearer new access token'));
 
-        return new Future.immediate(new http.Response('good job', 200));
+        return new Future.value(new http.Response('good job', 200));
       });
 
       expect(client.read(requestUri).then((_) {
         expect(client.credentials.accessToken, equals('new access token'));
       }), completes);
     });
   });
 
   group('with valid credentials', () {
     setUp(createHttpClient);
 
     test("sends a request with bearer authorization", () {
       var credentials = new oauth2.Credentials('access token');
       var client = new oauth2.Client('identifier', 'secret', credentials,
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('GET'));
         expect(request.url.toString(), equals(requestUri.toString()));
         expect(request.headers['authorization'],
             equals('Bearer access token'));
 
-        return new Future.immediate(new http.Response('good job', 200));
+        return new Future.value(new http.Response('good job', 200));
       });
 
       expect(client.read(requestUri), completion(equals('good job')));
     });
 
     test("can manually refresh the credentials", () {
       var credentials = new oauth2.Credentials(
           'access token', 'refresh token', tokenEndpoint);
       var client = new oauth2.Client('identifier', 'secret', credentials,
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('POST'));
         expect(request.url.toString(), equals(tokenEndpoint.toString()));
-        return new Future.immediate(new http.Response(JSON.stringify({
+        return new Future.value(new http.Response(JSON.stringify({
           'access_token': 'new access token',
           'token_type': 'bearer'
         }), 200, headers: {'content-type': 'application/json'}));
       });
 
       expect(client.refreshCredentials().then((_) {
         expect(client.credentials.accessToken, equals('new access token'));
       }), completes);
     });
 
@@ skipping 16 matching lines @@
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('GET'));
         expect(request.url.toString(), equals(requestUri.toString()));
         expect(request.headers['authorization'],
             equals('Bearer access token'));
 
         var authenticate = 'Bearer error="invalid_token", error_description='
             '"Something is terribly wrong."';
-        return new Future.immediate(new http.Response('bad job', 401,
+        return new Future.value(new http.Response('bad job', 401,
                 headers: {'www-authenticate': authenticate}));
       });
 
       expectFutureThrows(client.read(requestUri),
                          (e) => e is oauth2.AuthorizationException);
     });
 
     test('passes through a 401 response without www-authenticate', () {
       var credentials = new oauth2.Credentials('access token');
       var client = new oauth2.Client('identifier', 'secret', credentials,
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('GET'));
         expect(request.url.toString(), equals(requestUri.toString()));
         expect(request.headers['authorization'],
             equals('Bearer access token'));
 
-        return new Future.immediate(new http.Response('bad job', 401));
+        return new Future.value(new http.Response('bad job', 401));
       });
 
       expect(
           client.get(requestUri).then((response) => response.statusCode),
           completion(equals(401)));
     });
 
     test('passes through a 401 response with invalid www-authenticate', () {
       var credentials = new oauth2.Credentials('access token');
       var client = new oauth2.Client('identifier', 'secret', credentials,
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('GET'));
         expect(request.url.toString(), equals(requestUri.toString()));
         expect(request.headers['authorization'],
             equals('Bearer access token'));
 
         var authenticate = 'Bearer error="invalid_token", error_description='
           '"Something is terribly wrong.", ';
-        return new Future.immediate(new http.Response('bad job', 401,
+        return new Future.value(new http.Response('bad job', 401,
                 headers: {'www-authenticate': authenticate}));
       });
 
       expect(
           client.get(requestUri).then((response) => response.statusCode),
           completion(equals(401)));
     });
 
     test('passes through a 401 response with non-bearer www-authenticate', () {
       var credentials = new oauth2.Credentials('access token');
       var client = new oauth2.Client('identifier', 'secret', credentials,
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('GET'));
         expect(request.url.toString(), equals(requestUri.toString()));
         expect(request.headers['authorization'],
             equals('Bearer access token'));
 
-        return new Future.immediate(new http.Response('bad job', 401,
+        return new Future.value(new http.Response('bad job', 401,
                 headers: {'www-authenticate': 'Digest'}));
       });
 
       expect(
           client.get(requestUri).then((response) => response.statusCode),
           completion(equals(401)));
     });
 
     test('passes through a 401 response with non-OAuth2 www-authenticate', () {
       var credentials = new oauth2.Credentials('access token');
       var client = new oauth2.Client('identifier', 'secret', credentials,
           httpClient: httpClient);
 
       httpClient.expectRequest((request) {
         expect(request.method, equals('GET'));
         expect(request.url.toString(), equals(requestUri.toString()));
         expect(request.headers['authorization'],
             equals('Bearer access token'));
 
-        return new Future.immediate(new http.Response('bad job', 401,
+        return new Future.value(new http.Response('bad job', 401,
                 headers: {'www-authenticate': 'Bearer'}));
       });
 
       expect(
           client.get(requestUri).then((response) => response.statusCode),
           completion(equals(401)));
     });
   });
 }