OLD | NEW |
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
4 | 4 |
5 library dependency_validator; | 5 library dependency_validator; |
6 | 6 |
7 import 'dart:async'; | 7 import 'dart:async'; |
8 | 8 |
9 import '../entrypoint.dart'; | 9 import '../entrypoint.dart'; |
10 import '../hosted_source.dart'; | 10 import '../hosted_source.dart'; |
(...skipping 13 matching lines...) Expand all Loading... |
24 return Future.forEach(entrypoint.root.pubspec.dependencies, (dependency) { | 24 return Future.forEach(entrypoint.root.pubspec.dependencies, (dependency) { |
25 if (dependency.source is! HostedSource) { | 25 if (dependency.source is! HostedSource) { |
26 return _warnAboutSource(dependency); | 26 return _warnAboutSource(dependency); |
27 } | 27 } |
28 | 28 |
29 if (dependency.name == entrypoint.root.name) { | 29 if (dependency.name == entrypoint.root.name) { |
30 warnings.add('You don\'t need to explicitly depend on your own ' | 30 warnings.add('You don\'t need to explicitly depend on your own ' |
31 'package.\n' | 31 'package.\n' |
32 'Pub enables "package:${entrypoint.root.name}" imports ' | 32 'Pub enables "package:${entrypoint.root.name}" imports ' |
33 'implicitly.'); | 33 'implicitly.'); |
34 return new Future.immediate(null); | 34 return new Future.value(); |
35 } | 35 } |
36 | 36 |
37 if (dependency.constraint.isAny) _warnAboutConstraint(dependency); | 37 if (dependency.constraint.isAny) _warnAboutConstraint(dependency); |
38 | 38 |
39 return new Future.immediate(null); | 39 return new Future.value(); |
40 }); | 40 }); |
41 } | 41 } |
42 | 42 |
43 /// Warn that dependencies should use the hosted source. | 43 /// Warn that dependencies should use the hosted source. |
44 Future _warnAboutSource(PackageRef ref) { | 44 Future _warnAboutSource(PackageRef ref) { |
45 return entrypoint.cache.sources['hosted'] | 45 return entrypoint.cache.sources['hosted'] |
46 .getVersions(ref.name, ref.name) | 46 .getVersions(ref.name, ref.name) |
47 .catchError((e) => <Version>[]) | 47 .catchError((e) => <Version>[]) |
48 .then((versions) { | 48 .then((versions) { |
49 var constraint; | 49 var constraint; |
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
92 } | 92 } |
93 | 93 |
94 /// Returns the suggested version constraint for a dependency that was tested | 94 /// Returns the suggested version constraint for a dependency that was tested |
95 /// against [version]. | 95 /// against [version]. |
96 String _constraintForVersion(Version version) { | 96 String _constraintForVersion(Version version) { |
97 if (version.major != 0) return '">=$version <${version.major + 1}.0.0"'; | 97 if (version.major != 0) return '">=$version <${version.major + 1}.0.0"'; |
98 return '">=$version <${version.major}.${version.minor}.' | 98 return '">=$version <${version.major}.${version.minor}.' |
99 '${version.patch + 1}"'; | 99 '${version.patch + 1}"'; |
100 } | 100 } |
101 } | 101 } |
OLD | NEW |