Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: pkg/oauth2/test/client_test.dart

Issue 14070010: Refactor Future constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added co19 issue number. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/oauth2/test/authorization_code_grant_test.dart ('k') | pkg/oauth2/test/credentials_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/oauth2/test/client_test.dart
diff --git a/pkg/oauth2/test/client_test.dart b/pkg/oauth2/test/client_test.dart
index 434ea95fc3d1acb1e88d8f93f7a65262864df895..bac05485457a3c55b4bed23877db0598bb093336 100644
--- a/pkg/oauth2/test/client_test.dart
+++ b/pkg/oauth2/test/client_test.dart
@@ -57,7 +57,7 @@ void main() {
httpClient.expectRequest((request) {
expect(request.method, equals('POST'));
expect(request.url.toString(), equals(tokenEndpoint.toString()));
- return new Future.immediate(new http.Response(JSON.stringify({
+ return new Future.value(new http.Response(JSON.stringify({
'access_token': 'new access token',
'token_type': 'bearer'
}), 200, headers: {'content-type': 'application/json'}));
@@ -69,7 +69,7 @@ void main() {
expect(request.headers['authorization'],
equals('Bearer new access token'));
- return new Future.immediate(new http.Response('good job', 200));
+ return new Future.value(new http.Response('good job', 200));
});
expect(client.read(requestUri).then((_) {
@@ -92,7 +92,7 @@ void main() {
expect(request.headers['authorization'],
equals('Bearer access token'));
- return new Future.immediate(new http.Response('good job', 200));
+ return new Future.value(new http.Response('good job', 200));
});
expect(client.read(requestUri), completion(equals('good job')));
@@ -107,7 +107,7 @@ void main() {
httpClient.expectRequest((request) {
expect(request.method, equals('POST'));
expect(request.url.toString(), equals(tokenEndpoint.toString()));
- return new Future.immediate(new http.Response(JSON.stringify({
+ return new Future.value(new http.Response(JSON.stringify({
'access_token': 'new access token',
'token_type': 'bearer'
}), 200, headers: {'content-type': 'application/json'}));
@@ -144,7 +144,7 @@ void main() {
var authenticate = 'Bearer error="invalid_token", error_description='
'"Something is terribly wrong."';
- return new Future.immediate(new http.Response('bad job', 401,
+ return new Future.value(new http.Response('bad job', 401,
headers: {'www-authenticate': authenticate}));
});
@@ -163,7 +163,7 @@ void main() {
expect(request.headers['authorization'],
equals('Bearer access token'));
- return new Future.immediate(new http.Response('bad job', 401));
+ return new Future.value(new http.Response('bad job', 401));
});
expect(
@@ -184,7 +184,7 @@ void main() {
var authenticate = 'Bearer error="invalid_token", error_description='
'"Something is terribly wrong.", ';
- return new Future.immediate(new http.Response('bad job', 401,
+ return new Future.value(new http.Response('bad job', 401,
headers: {'www-authenticate': authenticate}));
});
@@ -204,7 +204,7 @@ void main() {
expect(request.headers['authorization'],
equals('Bearer access token'));
- return new Future.immediate(new http.Response('bad job', 401,
+ return new Future.value(new http.Response('bad job', 401,
headers: {'www-authenticate': 'Digest'}));
});
@@ -224,7 +224,7 @@ void main() {
expect(request.headers['authorization'],
equals('Bearer access token'));
- return new Future.immediate(new http.Response('bad job', 401,
+ return new Future.value(new http.Response('bad job', 401,
headers: {'www-authenticate': 'Bearer'}));
});
« no previous file with comments | « pkg/oauth2/test/authorization_code_grant_test.dart ('k') | pkg/oauth2/test/credentials_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698