Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: utils/pub/validator/utf8_readme.dart

Issue 14070010: Refactor Future constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added co19 issue number. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/validator/pubspec_field.dart ('k') | utils/pub/version_solver.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library utf8_readme_validator; 5 library utf8_readme_validator;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:utf'; 8 import 'dart:utf';
9 9
10 import 'package:pathos/path.dart' as path; 10 import 'package:pathos/path.dart' as path;
11 11
12 import '../entrypoint.dart'; 12 import '../entrypoint.dart';
13 import '../io.dart'; 13 import '../io.dart';
14 import '../utils.dart'; 14 import '../utils.dart';
15 import '../validator.dart'; 15 import '../validator.dart';
16 16
17 /// Validates that a package's README is valid utf-8. 17 /// Validates that a package's README is valid utf-8.
18 class Utf8ReadmeValidator extends Validator { 18 class Utf8ReadmeValidator extends Validator {
19 Utf8ReadmeValidator(Entrypoint entrypoint) 19 Utf8ReadmeValidator(Entrypoint entrypoint)
20 : super(entrypoint); 20 : super(entrypoint);
21 21
22 Future validate() { 22 Future validate() {
23 return new Future.of(() { 23 return new Future.sync(() {
24 var readme = entrypoint.root.readmePath; 24 var readme = entrypoint.root.readmePath;
25 if (readme == null) return; 25 if (readme == null) return;
26 var bytes = readBinaryFile(readme); 26 var bytes = readBinaryFile(readme);
27 try { 27 try {
28 // The second and third arguments here are the default values. The 28 // The second and third arguments here are the default values. The
29 // fourth tells [decodeUtf8] to throw an ArgumentError if `bytes` isn't 29 // fourth tells [decodeUtf8] to throw an ArgumentError if `bytes` isn't
30 // valid utf-8. 30 // valid utf-8.
31 decodeUtf8(bytes, 0, null, null); 31 decodeUtf8(bytes, 0, null, null);
32 } on ArgumentError catch (_) { 32 } on ArgumentError catch (_) {
33 warnings.add("$readme contains invalid UTF-8.\n" 33 warnings.add("$readme contains invalid UTF-8.\n"
34 "This will cause it to be displayed incorrectly on " 34 "This will cause it to be displayed incorrectly on "
35 "pub.dartlang.org."); 35 "pub.dartlang.org.");
36 } 36 }
37 }); 37 });
38 } 38 }
39 } 39 }
40 40
OLDNEW
« no previous file with comments | « utils/pub/validator/pubspec_field.dart ('k') | utils/pub/version_solver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698