Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: utils/tests/pub/validator/dependency_test.dart

Issue 14070010: Refactor Future constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added co19 issue number. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/tests/pub/test_pub.dart ('k') | utils/tests/pub/validator/size_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/validator/dependency_test.dart
diff --git a/utils/tests/pub/validator/dependency_test.dart b/utils/tests/pub/validator/dependency_test.dart
index de4d08e91626e0dc8590b5d5608e878a26dd1c4c..4001330aa9f665fc420fa3031b54fea463a370c1 100644
--- a/utils/tests/pub/validator/dependency_test.dart
+++ b/utils/tests/pub/validator/dependency_test.dart
@@ -38,9 +38,9 @@ setUpDependency(Map dep, {List<String> hostedVersions}) {
expect(request.url.path, equals("/packages/foo.json"));
if (hostedVersions == null) {
- return new Future.immediate(new http.Response("not found", 404));
+ return new Future.value(new http.Response("not found", 404));
} else {
- return new Future.immediate(new http.Response(json.stringify({
+ return new Future.value(new http.Response(json.stringify({
"name": "foo",
"uploaders": ["nweiz@google.com"],
"versions": hostedVersions
« no previous file with comments | « utils/tests/pub/test_pub.dart ('k') | utils/tests/pub/validator/size_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698