Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1405273002: Mach port scopers should use get() instead of type conversion operators (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Mach port scopers should use get() instead of type conversion operators In https://codereview.chromium.org/1411523006, the Mach port scopers are becoming better ScopedGenerics and are losing the type conversion operators in the process. This is needed to adapt to that change. get() is ugly, but being explicit about conversion isn’t a bad thing, and these scopers will gain functionality such as Pass() as part of the switch. As a bonus, some would-be uses of get() to check for valid port rights are becoming a more descriptive is_valid(). R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6c0d42ce9dee55eaa906865191e28df35b32910d

Patch Set 1 #

Patch Set 2 : Use is_valid() where possible #

Patch Set 3 : More is_valid() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -100 lines) Patch
M client/crashpad_client_mac.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M client/simulate_crash_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M handler/mac/crash_report_exception_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M handler/mac/exception_handler_server.h View 1 chunk +1 line, -1 line 0 comments Download
M handler/mac/exception_handler_server.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M test/mac/mach_multiprocess.cc View 1 4 chunks +11 lines, -11 lines 0 comments Download
M tools/mac/catch_exception_tool.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/mac/exception_port_tool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/child_port_handshake.cc View 1 6 chunks +10 lines, -9 lines 0 comments Download
M util/mach/exception_ports_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M util/mach/mach_extensions_test.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M util/mach/mach_message_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/notify_server_test.cc View 1 12 chunks +50 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
5 years, 2 months ago (2015-10-16 05:49:30 UTC) #3
Robert Sesek
LGTM
5 years, 2 months ago (2015-10-20 15:01:54 UTC) #4
Mark Mentovai
5 years, 2 months ago (2015-10-20 15:03:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
6c0d42ce9dee55eaa906865191e28df35b32910d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698