Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tools/mac/exception_port_tool.cc

Issue 1405273002: Mach port scopers should use get() instead of type conversion operators (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: More is_valid() Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/mac/catch_exception_tool.cc ('k') | util/mach/child_port_handshake.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mac/exception_port_tool.cc
diff --git a/tools/mac/exception_port_tool.cc b/tools/mac/exception_port_tool.cc
index e26c1bb063dbb87a33b36a208bd88c750b94eacd..b873e68b897611f3efeec3c82cb0970304fc67ba 100644
--- a/tools/mac/exception_port_tool.cc
+++ b/tools/mac/exception_port_tool.cc
@@ -195,7 +195,7 @@ void ShowBootstrapService(const std::string& service_name,
return;
}
- mach_send_right_pool->AddSendRight(service_port);
+ mach_send_right_pool->AddSendRight(service_port.get());
printf("service %s %#x\n", service_name.c_str(), service_port.get());
}
@@ -300,7 +300,7 @@ bool SetExceptionPort(const ExceptionHandlerDescription* description,
ExceptionPorts exception_ports(description->target_type, target_port);
if (!exception_ports.SetExceptionPort(description->mask,
- service_port,
+ service_port.get(),
description->behavior,
description->flavor)) {
return false;
« no previous file with comments | « tools/mac/catch_exception_tool.cc ('k') | util/mach/child_port_handshake.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698