tools/mac/catch_exception_tool.cc - Issue 1405273002: Mach port scopers should use get() instead of type conversion operators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mac/catch_exception_tool.cc

Issue 1405273002: Mach port scopers should use get() instead of type conversion operators (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: More is_valid() Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/mac/catch_exception_tool.cc

diff --git a/tools/mac/catch_exception_tool.cc b/tools/mac/catch_exception_tool.cc

index b70ce0a5b45cb4d6a48308d17dce01a9d260fd34..32c6aed20a13a79558ebb266a5a7003d8e139c00 100644

--- a/tools/mac/catch_exception_tool.cc

+++ b/tools/mac/catch_exception_tool.cc

@@ -301,7 +301,7 @@ int CatchExceptionToolMain(int argc, char* argv[]) {

}

mach_msg_return_t mr = MachMessageServer::Run(&universal_mach_exc_server,

- service_port,

+ service_port.get(),

MACH_MSG_OPTION_NONE,

options.persistent,

receive_large,

« no previous file with comments | « test/mac/mach_multiprocess.cc ('k') | tools/mac/exception_port_tool.cc » ('j') | no next file with comments »