handler/mac/crash_report_exception_handler.cc - Issue 1405273002: Mach port scopers should use get() instead of type conversion operators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: handler/mac/crash_report_exception_handler.cc

Issue 1405273002: Mach port scopers should use get() instead of type conversion operators (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: More is_valid() Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: handler/mac/crash_report_exception_handler.cc

diff --git a/handler/mac/crash_report_exception_handler.cc b/handler/mac/crash_report_exception_handler.cc

index a54cd0dd2120180420c9c02d6ad0a3d2ca16ee72..288148e9947093df6a7eb914bfb4d52fef36de7b 100644

--- a/handler/mac/crash_report_exception_handler.cc

+++ b/handler/mac/crash_report_exception_handler.cc

@@ -186,7 +186,7 @@ kern_return_t CrashReportExceptionHandler::CatchMachException(

// vendor.

base::mac::ScopedMachSendRight

system_crash_reporter_handler(SystemCrashReporterHandler());

- if (system_crash_reporter_handler) {

+ if (system_crash_reporter_handler.get()) {

// Make copies of mutable out parameters so that the system crash reporter

// can’t influence the state returned by this method.

thread_state_flavor_t flavor_forward = *flavor;

@@ -205,7 +205,7 @@ kern_return_t CrashReportExceptionHandler::CatchMachException(

// will be available.

kern_return_t kr = UniversalExceptionRaise(

EXCEPTION_STATE_IDENTITY | MACH_EXCEPTION_CODES,

- system_crash_reporter_handler,

+ system_crash_reporter_handler.get(),

thread,

task,

exception,

« no previous file with comments | « client/simulate_crash_mac.cc ('k') | handler/mac/exception_handler_server.h » ('j') | no next file with comments »