Mach port scopers should use get() instead of type conversion operators

handler/mac/crash_report_exception_handler.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 168 matching lines @@
     // Don’t forward simulated exceptions such as kMachExceptionSimulated to the
     // system crash reporter. Only forward the types of exceptions that it would
     // receive under normal conditions. Although the system crash reporter is
     // able to deal with other exceptions including simulated ones, forwarding
     // them to the system crash reporter could present the system’s crash UI for
     // processes that haven’t actually crashed, and could result in reports not
     // actually associated with crashes being sent to the operating system
     // vendor.
     base::mac::ScopedMachSendRight
         system_crash_reporter_handler(SystemCrashReporterHandler());
-    if (system_crash_reporter_handler) {
+    if (system_crash_reporter_handler.get()) {
       // Make copies of mutable out parameters so that the system crash reporter
       // can’t influence the state returned by this method.
       thread_state_flavor_t flavor_forward = *flavor;
       mach_msg_type_number_t new_state_forward_count = *new_state_count;
       std::vector<natural_t> new_state_forward(
           new_state, new_state + new_state_forward_count);
 
       // The system crash reporter requires the behavior to be
       // EXCEPTION_STATE_IDENTITY | MACH_EXCEPTION_CODES. It uses the identity
       // parameters but doesn’t appear to use the state parameters, including
       // |flavor|, and doesn’t care if they are 0 or invalid. As long as an
       // identity is available (checked above), any other exception behavior is
       // converted to what the system crash reporter wants, with the caveat that
       // problems may arise if the state wasn’t available and the system crash
       // reporter changes in the future to use it. However, normally, the state
       // will be available.
       kern_return_t kr = UniversalExceptionRaise(
           EXCEPTION_STATE_IDENTITY | MACH_EXCEPTION_CODES,
-          system_crash_reporter_handler,
+          system_crash_reporter_handler.get(),
           thread,
           task,
           exception,
           code,
           code_count,
           &flavor_forward,
           old_state,
           old_state_count,
           new_state_forward_count ? &new_state_forward[0] : nullptr,
           &new_state_forward_count);
       MACH_LOG_IF(WARNING, kr != KERN_SUCCESS, kr) << "UniversalExceptionRaise";
     }
   }
 
   ExcServerCopyState(
       behavior, old_state, old_state_count, new_state, new_state_count);
 
   return ExcServerSuccessfulReturnValue(exception, behavior, false);
 }
 
 }  // namespace crashpad