Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1411523006: mac: Make Mach port scopers better ScopedGenerics (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Make Mach port scopers better ScopedGenerics Previously, Pass() did not work correctly for ScopedMachReceiveRight, ScopedMachSendRight, or ScopedMachPortSet. These were defined as subclasses of ScopedGeneric<> with appropriate traits types. They did not have the full range of constructors made available by ScopedGeneric<>, and their Pass() methods referred to their ScopedGeneric<> superclass rather than their proper class types. This changes these scopers to work as ScopedGeneric<> intends, with a "using" or "typedef" declaration, so that names such as ScopedMachReceiveRight actually refer to the same type as the underlying ScopedGeneric<>. This allows Pass() and all other ScopedGeneric<> functionality to work as intended. Unfortunately, ScopedGeneric<> doesn't provide a type conversion operator to the underlying wrapped type, so many use sites need to be transformed to use the get() accessor. Many existing use sites already used this accessor. Committed: https://crrev.com/da902e18a4d31bc1d1534f85ab6cf30b4c4bcdfc Cr-Commit-Position: refs/heads/master@{#355112}

Patch Set 1 #

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -77 lines) Patch
M base/mac/scoped_mach_port.h View 1 chunk +5 lines, -24 lines 0 comments Download
M base/memory/shared_memory_mac_unittest.cc View 1 6 chunks +8 lines, -6 lines 0 comments Download
M base/process/process_metrics_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/sys_info_ios.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/time/time_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_io_surface_manager_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mach_broker_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_io_surface_manager_mac.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M ipc/attachment_broker_privileged_mac.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ipc/attachment_broker_privileged_mac_unittest.cc View 1 8 chunks +33 lines, -23 lines 0 comments Download
M ipc/attachment_broker_unprivileged_mac.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/mac/bootstrap_sandbox.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/mac/launchd_interception_server.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/mac/xpc_message_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Mark Mentovai
avi for content and overall review tsepez for ipc
5 years, 2 months ago (2015-10-16 06:50:52 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 2 months ago (2015-10-16 16:27:39 UTC) #3
Tom Sepez
lgtm
5 years, 2 months ago (2015-10-16 16:29:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411523006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411523006/20001
5 years, 2 months ago (2015-10-20 17:43:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 18:36:20 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 18:37:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da902e18a4d31bc1d1534f85ab6cf30b4c4bcdfc
Cr-Commit-Position: refs/heads/master@{#355112}

Powered by Google App Engine
This is Rietveld 408576698