Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404443004: Move //mojo/services/network/public/interfaces to //mojo/services/network/interfaces. (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move //mojo/services/network/public/interfaces to //mojo/services/network/interfaces. Also, update this directory to exactly match the one in monet at 0a814ed5512598e595c0ae7975a09d90a7a54e90 (aside from changes required by the move, this only updates the BUILD.gn in that directory in a minor way). R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2e11a3f27bd59b1215864252b13ea3e423a4f1a0

Patch Set 1 #

Patch Set 2 : add some missing dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -716 lines) Patch
M examples/forwarding_content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/go/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/go/http_handler.go View 1 chunk +1 line, -1 line 0 comments Download
M examples/go/http_server.go View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/http_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/http_handler/http_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/js/users-guide.md View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/js/wget.js View 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/wget/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/wget/wget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/BUILD.gn View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/dart/embedder/mojo_dart_state.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/authenticating_url_loader_interceptor/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/authenticating_url_loader_interceptor/interfaces/authenticating_url_loader_interceptor_meta_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/http_server/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/http_server/interfaces/http_server_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/mojo_services.gni View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
A + mojo/services/network/interfaces/cookie_store.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/host_resolver.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/http_connection.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/network/interfaces/http_message.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/http_server.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/net_address.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/network_service.mojom View 1 chunk +10 lines, -10 lines 0 comments Download
A + mojo/services/network/interfaces/tcp_bound_socket.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/network/interfaces/tcp_connected_socket.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/tcp_server_socket.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/network/interfaces/udp_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/network/interfaces/url_loader.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/url_loader_interceptor.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/network/interfaces/web_socket.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/services/network/public/interfaces/cookie_store.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/services/network/public/interfaces/host_resolver.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/network/public/interfaces/http_connection.mojom View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/services/network/public/interfaces/http_message.mojom View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/services/network/public/interfaces/http_server.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/services/network/public/interfaces/net_address.mojom View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +0 lines, -87 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_bound_socket.mojom View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_connected_socket.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/network/public/interfaces/tcp_server_socket.mojom View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/services/network/public/interfaces/udp_socket.mojom View 1 chunk +0 lines, -121 lines 0 comments Download
D mojo/services/network/public/interfaces/url_loader.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/network/public/interfaces/url_loader_interceptor.mojom View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/services/network/public/interfaces/web_socket.mojom View 1 chunk +0 lines, -60 lines 0 comments Download
M services/authenticating_url_loader_interceptor/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor.h View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M services/authentication/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/content_handler_app_service_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/debugger/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/debugger/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/http_server/connection.h View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/http_server/http_server_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/http_server/http_server_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/js/test/network_test.js View 1 chunk +1 line, -1 line 0 comments Download
M services/location/geocoder_service.js View 1 chunk +2 lines, -2 lines 0 comments Download
M services/nacl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/nacl/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/python/mojo_url_redirector/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/python/mojo_url_redirector/mojo_url_redirector_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/url_response_disk_cache/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/vanadium/security/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M services/vanadium/security/principal_service.go View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M shell/android/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/application_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/local_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/network_fetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/crash/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M shell/crash/crash_upload.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/crash/crash_upload.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/crash/crash_upload_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/shell_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tonic/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tonic/dart_library_provider_network.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-13 04:50:44 UTC) #1
jamesr
Why is android sad?
5 years, 2 months ago (2015-10-13 19:14:04 UTC) #2
viettrungluu
On 2015/10/13 19:14:04, jamesr wrote: > Why is android sad? Probably a missing dependency. Let ...
5 years, 2 months ago (2015-10-13 19:49:24 UTC) #3
viettrungluu
PTAL
5 years, 2 months ago (2015-10-13 20:04:29 UTC) #4
jamesr
lgtm
5 years, 2 months ago (2015-10-13 20:14:29 UTC) #5
viettrungluu
5 years, 2 months ago (2015-10-13 20:20:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2e11a3f27bd59b1215864252b13ea3e423a4f1a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698