Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1401363003: Rename DisplayItemList to PaintController (Closed)

Created:
5 years, 2 months ago by pdr.
Modified:
5 years, 2 months ago
Reviewers:
chrishtr, jbroman
CC:
apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj, devtools-reviews_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, yurys+blink_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DisplayItemList to PaintController This patch renames DisplayItemList to PaintController because the paint controller actually contains two lists of display items and handles updating them each frame (the merge/commit step). The PaintController owns two DisplayItems objects for the actual lists. This patch is a followup to [1] which factored DisplayItems (the list) out of DisplayItemList. A followup patch will rename DisplayItems to DisplayItemList to make this clear. [1] https://crrev.com/5243078103e8ab4753cfbf3b46058598c76931f0 BUG=537409 Committed: https://crrev.com/f92b760fedf42ff985d34e57e048e0b013ab0902 Cr-Commit-Position: refs/heads/master@{#353947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -2487 lines) Patch
M third_party/WebKit/Source/core/compositing/DisplayListCompositingBuilder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/compositing/DisplayListCompositingBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/compositing/DisplayListCompositingBuilderTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/CompositingRecorder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/core/paint/DisplayItemListPaintTest.h View 1 chunk +0 lines, -132 lines 0 comments Download
D third_party/WebKit/Source/core/paint/DisplayItemListPaintTest.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FloatClipRecorder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlinePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorderTest.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerFixedPositionRecorder.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp View 6 chunks +33 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp View 9 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 23 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScopeRecorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScopeRecorder.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollRecorder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/Transform3DRecorder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TransformRecorder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositedDisplayList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CachedDisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathRecorder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipRecorder.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemCacheSkipper.h View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h View 1 chunk +0 lines, -265 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp View 1 chunk +0 lines, -565 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp View 1 chunk +0 lines, -793 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 6 chunks +11 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 22 chunks +30 lines, -30 lines 0 comments Download
A + third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 25 chunks +163 lines, -163 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/README.md View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SubsequenceRecorder.cpp View 6 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageOverlayTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pdr.
5 years, 2 months ago (2015-10-13 23:33:00 UTC) #2
chrishtr
lgtm
5 years, 2 months ago (2015-10-13 23:36:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401363003/1
5 years, 2 months ago (2015-10-13 23:38:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 02:26:37 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 02:27:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f92b760fedf42ff985d34e57e048e0b013ab0902
Cr-Commit-Position: refs/heads/master@{#353947}

Powered by Google App Engine
This is Rietveld 408576698