third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h - Issue 1401363003: Rename DisplayItemList to PaintController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h

Issue 1401363003: Rename DisplayItemList to PaintController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/LayerFixedPositionRecorder.cpp ('k') | third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h

diff --git a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h

index 394bd7c8cae4cf3abc80d796e6483a714ccfdb62..d904957de1daabe348671e0cd403378302b4258c 100644

--- a/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h

+++ b/third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h

@@ -38,7 +38,7 @@ public:

LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject& layoutObject, DisplayItem::Type displayItemType, const FloatRect& clip, const LayoutPoint& paintOffset)

{

- updatePaintOffsetIfNeeded(context.displayItemList(), layoutObject, paintOffset);

+ updatePaintOffsetIfNeeded(context.paintController(), layoutObject, paintOffset);

// We may paint a delayed-invalidation object before it's actually invalidated.

if (layoutObject.fullPaintInvalidationReason() == PaintInvalidationDelayedFull)

m_cacheSkipper.emplace(context);

@@ -62,15 +62,15 @@ public:

#endif

private:

- static void updatePaintOffsetIfNeeded(DisplayItemList* displayItemList, const LayoutObject& layoutObject, const LayoutPoint& paintOffset)

+ static void updatePaintOffsetIfNeeded(PaintController* paintController, const LayoutObject& layoutObject, const LayoutPoint& paintOffset)

{

- if (!RuntimeEnabledFeatures::slimmingPaintOffsetCachingEnabled() || displayItemList->skippingCache())

+ if (!RuntimeEnabledFeatures::slimmingPaintOffsetCachingEnabled() || paintController->skippingCache())

return;

if (layoutObject.paintOffsetChanged(paintOffset))

- displayItemList->invalidatePaintOffset(layoutObject);

+ paintController->invalidatePaintOffset(layoutObject);

else

- ASSERT(!displayItemList->paintOffsetWasInvalidated(layoutObject.displayItemClient()) || !displayItemList->clientCacheIsValid(layoutObject.displayItemClient()));

+ ASSERT(!paintController->paintOffsetWasInvalidated(layoutObject.displayItemClient()) || !paintController->clientCacheIsValid(layoutObject.displayItemClient()));

layoutObject.mutableForPainting().setPreviousPaintOffset(paintOffset);

}