Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New (Closed)

Created:
5 years, 2 months ago by jamesr
Modified:
5 years, 2 months ago
Reviewers:
viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove callers of mojo::Array<size_t> constructor in favor of ::New This creates an ambiguity with Array(0) if we try to add a mojo::Array(std::nullptr_t) constructor. This just removes callers, it doesn't remove the constructor itself. I'll remove the constructor after verifying downstream consumers won't be broken. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc335c09730683e61693b125d0f95cef1d6da858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -87 lines) Patch
M apps/moterm/moterm_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/native_run_app/native_run_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/array_string/array_string_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/array_string/array_string_type_converters_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M mojo/dart/embedder/test/dart_to_cpp_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/array.h View 3 chunks +7 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/array_unittest.cc View 17 chunks +20 lines, -20 lines 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/map_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/type_conversion_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/files/public/c/lib/file_fd_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/clipboard/clipboard_standalone_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/files/directory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/files/file_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/js/system/tests/js_to_cpp_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/native_support/redirectors.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/reaper/reaper_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/display_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/surfaces_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
5 years, 2 months ago (2015-10-09 17:43:37 UTC) #2
viettrungluu
5 years, 2 months ago (2015-10-09 18:26:56 UTC) #3
viettrungluu
lgtm
5 years, 2 months ago (2015-10-09 18:27:02 UTC) #4
jamesr
5 years, 2 months ago (2015-10-10 00:23:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc335c09730683e61693b125d0f95cef1d6da858 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698