Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: mojo/public/cpp/bindings/lib/array_serialization.h

Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/array.h ('k') | mojo/public/cpp/bindings/tests/array_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/array_serialization.h
diff --git a/mojo/public/cpp/bindings/lib/array_serialization.h b/mojo/public/cpp/bindings/lib/array_serialization.h
index dc98245faaabba26f212a4a2a4b1b455326fb245..3ab0f018cb626077eaeb3af2a3d91641d509886a 100644
--- a/mojo/public/cpp/bindings/lib/array_serialization.h
+++ b/mojo/public/cpp/bindings/lib/array_serialization.h
@@ -106,7 +106,7 @@ struct ArraySerializer<bool, bool, false> {
static void DeserializeElements(Array_Data<bool>* input,
Array<bool>* output) {
- Array<bool> result(input->size());
+ auto result = Array<bool>::New(input->size());
// TODO(darin): Can this be a memcpy somehow instead of a bit-by-bit copy?
for (size_t i = 0; i < input->size(); ++i)
result.at(i) = input->at(i);
@@ -144,7 +144,7 @@ struct ArraySerializer<ScopedHandleBase<H>, H, false> {
static void DeserializeElements(Array_Data<H>* input,
Array<ScopedHandleBase<H>>* output) {
- Array<ScopedHandleBase<H>> result(input->size());
+ auto result = Array<ScopedHandleBase<H>>::New(input->size());
for (size_t i = 0; i < input->size(); ++i)
result.at(i) = MakeScopedHandle(FetchAndReset(&input->at(i)));
output->Swap(&result);
@@ -191,7 +191,7 @@ struct ArraySerializer<
static void DeserializeElements(Array_Data<S_Data*>* input,
Array<S>* output) {
- Array<S> result(input->size());
+ auto result = Array<S>::New(input->size());
for (size_t i = 0; i < input->size(); ++i) {
DeserializeCaller::Run(input->at(i), &result[i]);
}
@@ -304,7 +304,7 @@ struct ArraySerializer<U, U_Data, true> {
}
static void DeserializeElements(Array_Data<U_Data>* input, Array<U>* output) {
- Array<U> result(input->size());
+ auto result = Array<U>::New(input->size());
for (size_t i = 0; i < input->size(); ++i) {
auto& elem = input->at(i);
if (!elem.is_null()) {
« no previous file with comments | « mojo/public/cpp/bindings/array.h ('k') | mojo/public/cpp/bindings/tests/array_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698