Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/sample_service_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
index 6fea3a401d2df03e207069a50a828bb793b9e83e..296b83caea4f69809c614f46b18c08a146118c71 100644
--- a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
@@ -43,7 +43,7 @@ FooPtr MakeFoo() {
bar->gamma = 60;
bar->type = Bar::Type::VERTICAL;
- mojo::Array<BarPtr> extra_bars(3);
+ auto extra_bars = mojo::Array<BarPtr>::New(3);
for (size_t i = 0; i < extra_bars.size(); ++i) {
Bar::Type type = i % 2 == 0 ? Bar::Type::VERTICAL : Bar::Type::HORIZONTAL;
BarPtr bar(Bar::New());
@@ -55,12 +55,12 @@ FooPtr MakeFoo() {
extra_bars[i] = bar.Pass();
}
- mojo::Array<uint8_t> data(10);
+ auto data = mojo::Array<uint8_t>::New(10);
for (size_t i = 0; i < data.size(); ++i)
data[i] = static_cast<uint8_t>(data.size() - i);
- mojo::Array<mojo::ScopedDataPipeConsumerHandle> input_streams(2);
- mojo::Array<mojo::ScopedDataPipeProducerHandle> output_streams(2);
+ auto input_streams = mojo::Array<mojo::ScopedDataPipeConsumerHandle>::New(2);
+ auto output_streams = mojo::Array<mojo::ScopedDataPipeProducerHandle>::New(2);
for (size_t i = 0; i < input_streams.size(); ++i) {
MojoCreateDataPipeOptions options;
options.struct_size = sizeof(MojoCreateDataPipeOptions);
@@ -74,9 +74,9 @@ FooPtr MakeFoo() {
output_streams[i] = producer.Pass();
}
- mojo::Array<mojo::Array<bool>> array_of_array_of_bools(2);
+ auto array_of_array_of_bools = mojo::Array<mojo::Array<bool>>::New(2);
for (size_t i = 0; i < 2; ++i) {
- mojo::Array<bool> array_of_bools(2);
+ auto array_of_bools = mojo::Array<bool>::New(2);
for (size_t j = 0; j < 2; ++j)
array_of_bools[j] = j;
array_of_array_of_bools[i] = array_of_bools.Pass();
« no previous file with comments | « mojo/public/cpp/bindings/tests/map_unittest.cc ('k') | mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698