mojo/public/cpp/bindings/tests/type_conversion_unittest.cc - Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/type_conversion_unittest.cc

Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/type_conversion_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/type_conversion_unittest.cc b/mojo/public/cpp/bindings/tests/type_conversion_unittest.cc

index 776ac14bfeac37ab4dcdba5341ddeada9569ba4d..328f5b783feb1aecd4221ec0ee7fc2a8b3e3bb3f 100644

--- a/mojo/public/cpp/bindings/tests/type_conversion_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/type_conversion_unittest.cc

@@ -158,7 +158,7 @@ TEST(TypeConversionTest, CustomTypeConverter_Array_Null) {

TEST(TypeConversionTest, CustomTypeConverter_Array) {

const RedmondRect kBase = {10, 20, 30, 40};

- Array<RectPtr> rects(10);

+ auto rects = Array<RectPtr>::New(10);

for (size_t i = 0; i < rects.size(); ++i) {

RedmondRect rr = kBase;

rr.left += static_cast<int32_t>(i);