Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: mojo/public/cpp/bindings/tests/struct_unittest.cc

Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/struct_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/struct_unittest.cc b/mojo/public/cpp/bindings/tests/struct_unittest.cc
index 283dd8eea9db2b93efd23e5c0056e7c2bb09c42c..9060c73fee74a1f6beda7ae568ba4c91937de95b 100644
--- a/mojo/public/cpp/bindings/tests/struct_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/struct_unittest.cc
@@ -35,7 +35,7 @@ MultiVersionStructPtr MakeMultiVersionStruct() {
output->f_int32 = 123;
output->f_rect = MakeRect(5);
output->f_string = "hello";
- output->f_array = Array<int8_t>(3);
+ output->f_array = Array<int8_t>::New(3);
output->f_array[0] = 10;
output->f_array[1] = 9;
output->f_array[2] = 8;
@@ -122,7 +122,7 @@ TEST_F(StructTest, Clone) {
clone_region = region.Clone();
EXPECT_EQ(region->name, clone_region->name);
- region->rects = Array<RectPtr>(2);
+ region->rects = Array<RectPtr>::New(2);
region->rects[1] = MakeRect();
clone_region = region.Clone();
EXPECT_EQ(2u, clone_region->rects.size());
@@ -292,7 +292,7 @@ TEST_F(StructTest, Versioning_OldToNew) {
input->f_int32 = 123;
input->f_rect = MakeRect(5);
input->f_string = "hello";
- input->f_array = Array<int8_t>(3);
+ input->f_array = Array<int8_t>::New(3);
input->f_array[0] = 10;
input->f_array[1] = 9;
input->f_array[2] = 8;
@@ -300,7 +300,7 @@ TEST_F(StructTest, Versioning_OldToNew) {
expected_output->f_int32 = 123;
expected_output->f_rect = MakeRect(5);
expected_output->f_string = "hello";
- expected_output->f_array = Array<int8_t>(3);
+ expected_output->f_array = Array<int8_t>::New(3);
expected_output->f_array[0] = 10;
expected_output->f_array[1] = 9;
expected_output->f_array[2] = 8;
@@ -316,7 +316,7 @@ TEST_F(StructTest, Versioning_OldToNew) {
input->f_int32 = 123;
input->f_rect = MakeRect(5);
input->f_string = "hello";
- input->f_array = Array<int8_t>(3);
+ input->f_array = Array<int8_t>::New(3);
input->f_array[0] = 10;
input->f_array[1] = 9;
input->f_array[2] = 8;
@@ -327,7 +327,7 @@ TEST_F(StructTest, Versioning_OldToNew) {
expected_output->f_int32 = 123;
expected_output->f_rect = MakeRect(5);
expected_output->f_string = "hello";
- expected_output->f_array = Array<int8_t>(3);
+ expected_output->f_array = Array<int8_t>::New(3);
expected_output->f_array[0] = 10;
expected_output->f_array[1] = 9;
expected_output->f_array[2] = 8;
@@ -351,7 +351,7 @@ TEST_F(StructTest, Versioning_NewToOld) {
expected_output->f_int32 = 123;
expected_output->f_rect = MakeRect(5);
expected_output->f_string = "hello";
- expected_output->f_array = Array<int8_t>(3);
+ expected_output->f_array = Array<int8_t>::New(3);
expected_output->f_array[0] = 10;
expected_output->f_array[1] = 9;
expected_output->f_array[2] = 8;
@@ -372,7 +372,7 @@ TEST_F(StructTest, Versioning_NewToOld) {
expected_output->f_int32 = 123;
expected_output->f_rect = MakeRect(5);
expected_output->f_string = "hello";
- expected_output->f_array = Array<int8_t>(3);
+ expected_output->f_array = Array<int8_t>::New(3);
expected_output->f_array[0] = 10;
expected_output->f_array[1] = 9;
expected_output->f_array[2] = 8;

Powered by Google App Engine
This is Rietveld 408576698