services/files/file_impl.cc - Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/files/file_impl.cc

Issue 1397133002: Remove callers of mojo::Array<size_t> constructor in favor of ::New (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/files/file_impl.cc

diff --git a/services/files/file_impl.cc b/services/files/file_impl.cc

index ba70aad7c5f7d484a8de312e463486bb510208c8..6281633b6e53d70c95fe4fe69fc0f76eab44666c 100644

--- a/services/files/file_impl.cc

+++ b/services/files/file_impl.cc

@@ -98,7 +98,7 @@ void FileImpl::Read(uint32_t num_bytes_to_read,

}

- Array<uint8_t> bytes_read(num_bytes_to_read);

+ auto bytes_read = Array<uint8_t>::New(num_bytes_to_read);

ssize_t num_bytes_read = HANDLE_EINTR(

read(file_fd_.get(), &bytes_read.front(), num_bytes_to_read));

if (num_bytes_read < 0) {

« no previous file with comments | « services/files/directory_impl.cc ('k') | services/js/system/tests/js_to_cpp_tests.cc » ('j') | no next file with comments »