Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths. (Closed)

Created:
5 years, 2 months ago by M-A Ruel
Modified:
5 years, 2 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add an assert to ensure UTF-8 locale when handling file paths. - Switch many calls from shutil.rmtree() to file_path.rmtree(). - Add call to fix_encoding.fix_encoding() to fix the locale. This was silently assumed and may cause problems when the path is not pure ASCII. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/d9a337e2fd5151eac24b3164963e086091d769a3

Patch Set 1 : . #

Patch Set 2 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -43 lines) Patch
M appengine/components/tests/endpoints_smoke_test.py View 1 2 chunks +9 lines, -4 lines 0 comments Download
M appengine/components/tool_support/local_app.py View 2 chunks +3 lines, -1 line 0 comments Download
M appengine/swarming/local_smoke_test.py View 6 chunks +6 lines, -4 lines 0 comments Download
M appengine/swarming/remote_smoke_test.py View 4 chunks +7 lines, -2 lines 0 comments Download
M appengine/swarming/server/bot_code_test.py View 3 chunks +9 lines, -2 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/bot_main_test.py View 3 chunks +4 lines, -1 line 0 comments Download
M appengine/swarming/swarming_bot/bot_code/task_runner_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/swarming/swarming_bot/main_test.py View 4 chunks +4 lines, -2 lines 0 comments Download
M appengine/swarming/tools/start_bot.py View 4 chunks +4 lines, -2 lines 0 comments Download
M appengine/swarming/tools/start_servers.py View 2 chunks +6 lines, -0 lines 0 comments Download
M client/tests/file_path_test.py View 5 chunks +14 lines, -10 lines 0 comments Download
M client/tests/isolate_format_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M client/tests/isolate_smoke_test.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M client/tests/isolate_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M client/tests/isolated_format_test.py View 4 chunks +4 lines, -2 lines 0 comments Download
M client/tests/isolateserver_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M client/tests/logging_utils_test.py View 3 chunks +4 lines, -2 lines 0 comments Download
M client/tests/run_isolated_smoke_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M client/tests/run_isolated_test.py View 4 chunks +3 lines, -2 lines 0 comments Download
M client/tests/swarming_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M client/tests/trace_inputs_smoke_test.py View 3 chunks +3 lines, -1 line 0 comments Download
M client/tests/zip_package_test.py View 4 chunks +7 lines, -3 lines 0 comments Download
M client/tools/run_on_bots.py View 2 chunks +2 lines, -1 line 0 comments Download
M client/tools/run_swarming_tests_on_swarming.py View 3 chunks +2 lines, -2 lines 0 comments Download
M client/tools/zip_profiler.py View 3 chunks +4 lines, -2 lines 0 comments Download
M client/utils/file_path.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
M-A Ruel
My plan is that if anything breaks due to this CL, I'll comment out the ...
5 years, 2 months ago (2015-10-06 15:41:03 UTC) #5
Vadim Sh.
lgtm
5 years, 2 months ago (2015-10-06 18:23:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390773002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390773002/80001
5 years, 2 months ago (2015-10-06 18:46:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/176)
5 years, 2 months ago (2015-10-06 18:51:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390773002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390773002/100001
5 years, 2 months ago (2015-10-06 19:04:58 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 19:08:11 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:100001) as
https://github.com/luci/luci-py/commit/d9a337e2fd5151eac24b3164963e086091d769a3

Powered by Google App Engine
This is Rietveld 408576698