appengine/components/tool_support/local_app.py - Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/components/tool_support/local_app.py

Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths. (Closed) Base URL: git@github.com:luci/luci-py.git@master

Patch Set: More fixes Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/components/tool_support/local_app.py

diff --git a/appengine/components/tool_support/local_app.py b/appengine/components/tool_support/local_app.py

index e8b13ac60f796de7be0f31efaa6b9bbc78fdaaf9..380b83644be3620052ea10acb067c178881de017 100644

--- a/appengine/components/tool_support/local_app.py

+++ b/appengine/components/tool_support/local_app.py

@@ -24,6 +24,8 @@ import urllib2

from . import gae_sdk_utils

+from utils import file_path

def terminate_with_parent():

"""Sets up current process to receive SIGTERM when its parent dies.

@@ -208,7 +210,7 @@ class LocalApplication(object):

self._log = f.read()

if not leak:

try:

- shutil.rmtree(self._temp_root)

+ file_path.rmtree(self._temp_root)

except OSError as e:

# Log but ignore it to not mask other errors.

print >> sys.stderr, str(e)