Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: client/tests/logging_utils_test.py

Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths. (Closed) Base URL: git@github.com:luci/luci-py.git@master
Patch Set: More fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/isolateserver_test.py ('k') | client/tests/run_isolated_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tests/logging_utils_test.py
diff --git a/client/tests/logging_utils_test.py b/client/tests/logging_utils_test.py
index 60285f227b486baa95c5fb739b65a5f1c6ce6e02..01e44b1bbd69aae1445c098cf226396b08f66d80 100755
--- a/client/tests/logging_utils_test.py
+++ b/client/tests/logging_utils_test.py
@@ -8,13 +8,14 @@ import os
import subprocess
import sys
import tempfile
-import shutil
import unittest
import re
THIS_FILE = os.path.abspath(__file__)
sys.path.insert(0, os.path.dirname(os.path.dirname(THIS_FILE)))
+from third_party.depot_tools import fix_encoding
+from utils import file_path
from utils import logging_utils
@@ -40,7 +41,7 @@ class Test(unittest.TestCase):
def tearDown(self):
try:
- shutil.rmtree(self.tmp)
+ file_path.rmtree(self.tmp)
finally:
super(Test, self).tearDown()
@@ -114,4 +115,5 @@ def main():
if __name__ == '__main__':
+ fix_encoding.fix_encoding()
sys.exit(main())
« no previous file with comments | « client/tests/isolateserver_test.py ('k') | client/tests/run_isolated_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698