Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: client/tools/run_on_bots.py

Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths. (Closed) Base URL: git@github.com:luci/luci-py.git@master
Patch Set: More fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/zip_package_test.py ('k') | client/tools/run_swarming_tests_on_swarming.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tools/run_on_bots.py
diff --git a/client/tools/run_on_bots.py b/client/tools/run_on_bots.py
index 9e3eff1ddb4d489df9c1950daf95ba36b66f326b..33f2f5e3fd12a5047cff59ed876e2c4d436ac7f2 100755
--- a/client/tools/run_on_bots.py
+++ b/client/tools/run_on_bots.py
@@ -26,6 +26,7 @@ import parallel_execution
from third_party import colorama
from third_party.depot_tools import fix_encoding
+from utils import file_path
from utils import tools
@@ -67,7 +68,7 @@ def archive(isolate_server, script):
]
return subprocess.check_output(cmd, cwd=ROOT_DIR).split()[0]
finally:
- shutil.rmtree(tempdir)
+ file_path.rmtree(tempdir)
def run_serial(
« no previous file with comments | « client/tests/zip_package_test.py ('k') | client/tools/run_swarming_tests_on_swarming.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698