client/utils/file_path.py - Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/utils/file_path.py

Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths. (Closed) Base URL: git@github.com:luci/luci-py.git@master

Patch Set: More fixes Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/utils/file_path.py

diff --git a/client/utils/file_path.py b/client/utils/file_path.py

index 04294330ce8b510c77253826c7478f73cf424632..02cf766be9848bcfa8c0415fed9093d192baa377 100644

--- a/client/utils/file_path.py

+++ b/client/utils/file_path.py

@@ -873,6 +873,7 @@ def rmtree(root):

"""

# Do not assert here yet because this would break too much code.

root = unicode(root)

+ assert sys.getdefaultencoding() == 'utf-8', sys.getdefaultencoding()

make_tree_deleteable(root)

logging.info('rmtree(%s)', root)

« no previous file with comments | « client/tools/zip_profiler.py ('k') | no next file » | no next file with comments »