Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: client/tests/trace_inputs_smoke_test.py

Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths. (Closed) Base URL: git@github.com:luci/luci-py.git@master
Patch Set: More fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/swarming_test.py ('k') | client/tests/zip_package_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tests/trace_inputs_smoke_test.py
diff --git a/client/tests/trace_inputs_smoke_test.py b/client/tests/trace_inputs_smoke_test.py
index afd8bbdc5e0b0056da78c11656a3e7c23f625369..10a44e2a9d804467717a259817c7ddfcc1fe6b1c 100755
--- a/client/tests/trace_inputs_smoke_test.py
+++ b/client/tests/trace_inputs_smoke_test.py
@@ -19,6 +19,7 @@ ROOT_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.insert(0, ROOT_DIR)
import trace_inputs
+from third_party.depot_tools import fix_encoding
from utils import file_path
from utils import threading_utils
@@ -101,7 +102,7 @@ class TraceInputsBase(unittest.TestCase):
if VERBOSE:
print 'Leaking: %s' % self.tempdir
else:
- shutil.rmtree(self.tempdir)
+ file_path.rmtree(self.tempdir)
@staticmethod
def get_child_command(from_data):
@@ -722,6 +723,7 @@ class TraceInputsImport(TraceInputsBase):
if __name__ == '__main__':
+ fix_encoding.fix_encoding()
VERBOSE = '-v' in sys.argv
logging.basicConfig(level=logging.DEBUG if VERBOSE else logging.ERROR)
if VERBOSE:
« no previous file with comments | « client/tests/swarming_test.py ('k') | client/tests/zip_package_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698