Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Issue 1375363003: Factor out VisualBench timing code into a helper class (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Factor out VisualBench timing code into a helper class BUG=skia: Committed: https://skia.googlesource.com/skia/+/98d2e2f095d9a5b784a32cfc2c34b30735dedcc3

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 9

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -5409 lines) Patch
M bench/BigPathBench.cpp View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
D bench/BigPathBench.inc View 1 2 1 chunk +0 lines, -5148 lines 0 comments Download
A + tools/BigPathBench.inc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + tools/VisualBench/TimingStateMachine.h View 1 2 3 chunks +44 lines, -43 lines 0 comments Download
A tools/VisualBench/TimingStateMachine.cpp View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 1 2 3 chunks +38 lines, -1 line 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.h View 2 chunks +2 lines, -46 lines 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.cpp View 1 7 chunks +17 lines, -165 lines 0 comments Download
M tools/sk_tool_utils.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
joshualitt
This code moves a bunch of the timing code out of VisualLightweightBenchModule. In a follow ...
5 years, 2 months ago (2015-10-02 16:30:31 UTC) #2
robertphillips
lgtm + mainly dox suggestions https://codereview.chromium.org/1375363003/diff/20001/tools/VisualBench/TimingStateMachine.cpp File tools/VisualBench/TimingStateMachine.cpp (right): https://codereview.chromium.org/1375363003/diff/20001/tools/VisualBench/TimingStateMachine.cpp#newcode5 tools/VisualBench/TimingStateMachine.cpp:5: * found in the ...
5 years, 2 months ago (2015-10-05 13:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375363003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375363003/40001
5 years, 2 months ago (2015-10-05 14:16:17 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 14:23:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/98d2e2f095d9a5b784a32cfc2c34b30735dedcc3

Powered by Google App Engine
This is Rietveld 408576698