Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1382883003: move visual bench interactive module to timing state machine (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vb
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move visual bench interactive module to timing state machine BUG=skia: Committed: https://skia.googlesource.com/skia/+/dc5db595143613bbde2b7af5295254120ef7d98c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -165 lines) Patch
M tools/VisualBench/TimingStateMachine.h View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/VisualBench/TimingStateMachine.cpp View 2 chunks +14 lines, -8 lines 0 comments Download
M tools/VisualBench/VisualInteractiveModule.h View 2 chunks +3 lines, -38 lines 0 comments Download
M tools/VisualBench/VisualInteractiveModule.cpp View 4 chunks +24 lines, -118 lines 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1375363003 Patch 40001

Dependent Patchsets:

Issue 1386933002 Patch 1
Issue 1386933002 Patch 20001
Issue 1386933002 Patch 40001
Issue 1386933002 Patch 60001
Issue 1386933002 Patch 80001

Messages

Total messages: 11 (4 generated)
joshualitt
ptal. I have one more follow on which further cleans this up.
5 years, 2 months ago (2015-10-05 14:20:11 UTC) #2
jvanverth1
lgtm
5 years, 2 months ago (2015-10-05 15:52:14 UTC) #3
robertphillips
lgtm
5 years, 2 months ago (2015-10-05 16:06:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382883003/1
5 years, 2 months ago (2015-10-05 16:11:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3474)
5 years, 2 months ago (2015-10-05 16:20:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382883003/1
5 years, 2 months ago (2015-10-05 20:18:05 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:25:02 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dc5db595143613bbde2b7af5295254120ef7d98c

Powered by Google App Engine
This is Rietveld 408576698