Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1372373002: bindings: Reduces the custom registration of methods. (Closed)

Created:
5 years, 2 months ago by Yuki
Modified:
5 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Reduces the custom registration of methods. Reduces the custom registration of methods. Also supports per-member *static* [Exposed] operation. With this CL, Notification.requestPermission() is exposed only when the global object is Window. BUG=43394, 516274, 442139 Committed: https://crrev.com/6cbbe2653f6371dc632a51dc54af3856624fc0ef Cr-Commit-Position: refs/heads/master@{#352006}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -76 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h View 1 2 3 4 chunks +11 lines, -7 lines 2 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 2 3 8 chunks +53 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_methods.py View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 2 3 2 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.idl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Yuki
Could you review this CL?
5 years, 2 months ago (2015-10-02 08:24:04 UTC) #2
Peter Beverloo
On 2015/10/02 08:24:04, Yuki wrote: > Could you review this CL? Thank you for the ...
5 years, 2 months ago (2015-10-02 09:21:57 UTC) #3
haraken
LGTM https://codereview.chromium.org/1372373002/diff/60001/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h (right): https://codereview.chromium.org/1372373002/diff/60001/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h#newcode77 third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h:77: unsigned settings : 8; // v8::AccessControl 4 bit ...
5 years, 2 months ago (2015-10-02 09:33:40 UTC) #4
Yuki
https://codereview.chromium.org/1372373002/diff/60001/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h (right): https://codereview.chromium.org/1372373002/diff/60001/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h#newcode77 third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h:77: unsigned settings : 8; // v8::AccessControl On 2015/10/02 09:33:40, ...
5 years, 2 months ago (2015-10-02 10:36:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372373002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372373002/60001
5 years, 2 months ago (2015-10-02 10:37:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-02 11:54:57 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 11:55:39 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/6cbbe2653f6371dc632a51dc54af3856624fc0ef
Cr-Commit-Position: refs/heads/master@{#352006}

Powered by Google App Engine
This is Rietveld 408576698