bindings: Reduces the custom registration of methods.

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 56 matching lines @@
     // the instance or the prototype ObjectTemplate, based on |instanceOrPrototypeConfiguration|.
     struct AttributeConfiguration {
         AttributeConfiguration& operator=(const AttributeConfiguration&) = delete;
         DISALLOW_ALLOCATION();
         const char* const name;
         v8::AccessorNameGetterCallback getter;
         v8::AccessorNameSetterCallback setter;
         v8::AccessorNameGetterCallback getterForMainWorld;
         v8::AccessorNameSetterCallback setterForMainWorld;
         const WrapperTypeInfo* data;
-        v8::AccessControl settings;
-        v8::PropertyAttribute attribute;
+        unsigned settings : 8; // v8::AccessControl

[haraken, 2015/10/02 09:33:40]

4 bit looks enough though.

[Yuki, 2015/10/02 10:36:48]

Yes, that's true.  But v8.h is out of our (direct) control, so I don't want to
rely on the definition of v8::AccessControl too much.  In future, V8 could use
more bits.

+        unsigned attribute : 8; // v8::PropertyAttribute
         unsigned exposeConfiguration : 1; // ExposeConfiguration
         unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration
         unsigned holderCheckConfiguration : 1; // HolderCheckConfiguration
     };
 
     static void installAttributes(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, const AttributeConfiguration*, size_t attributeCount);
 
     static void installAttribute(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, const AttributeConfiguration&);
 
     // AccessorConfiguration translates into calls to SetAccessorProperty()
     // on prototype ObjectTemplate.
     struct AccessorConfiguration {
         AccessorConfiguration& operator=(const AccessorConfiguration&) = delete;
         DISALLOW_ALLOCATION();
         const char* const name;
         v8::FunctionCallback getter;
         v8::FunctionCallback setter;
         v8::FunctionCallback getterForMainWorld;
         v8::FunctionCallback setterForMainWorld;
         const WrapperTypeInfo* data;
-        v8::AccessControl settings;
-        v8::PropertyAttribute attribute;
+        unsigned settings : 8; // v8::AccessControl
+        unsigned attribute : 8; // v8::PropertyAttribute
         unsigned exposeConfiguration : 1; // ExposeConfiguration
         unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration
         unsigned holderCheckConfiguration : 1; // HolderCheckConfiguration
     };
 
     static void installAccessors(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, const AccessorConfiguration*, size_t accessorCount);
 
     static void installAccessor(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, const AccessorConfiguration&);
 
     static void installAccessor(v8::Isolate*, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface, v8::Local<v8::Signature>, const AccessorConfiguration&);
@@ skipping 42 matching lines @@
         v8::Local<v8::Name> methodName(v8::Isolate* isolate) const { return v8AtomicString(isolate, name); }
         v8::FunctionCallback callbackForWorld(const DOMWrapperWorld& world) const
         {
             return world.isMainWorld() && callbackForMainWorld ? callbackForMainWorld : callback;
         }
 
         const char* const name;
         v8::FunctionCallback callback;
         v8::FunctionCallback callbackForMainWorld;
         int length;
+        unsigned attribute : 8; // v8::PropertyAttribute
         unsigned exposeConfiguration : 1; // ExposeConfiguration
         unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration
     };
 
     struct SymbolKeyedMethodConfiguration {
         SymbolKeyedMethodConfiguration& operator=(const SymbolKeyedMethodConfiguration&) = delete;
         DISALLOW_ALLOCATION();
         v8::Local<v8::Name> methodName(v8::Isolate* isolate) const { return getSymbol(isolate); }
         v8::FunctionCallback callbackForWorld(const DOMWrapperWorld&) const
         {
             return callback;
         }
 
         v8::Local<v8::Symbol> (*getSymbol)(v8::Isolate*);
         v8::FunctionCallback callback;
         // SymbolKeyedMethodConfiguration doesn't support per-world bindings.
         int length;
+        unsigned attribute : 8; // v8::PropertyAttribute
         unsigned exposeConfiguration : 1; // ExposeConfiguration
         unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration
     };
 
-    static void installMethods(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration*, size_t methodCount);
+    static void installMethods(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, const MethodConfiguration*, size_t methodCount);
 
-    static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration&);
+    static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, const MethodConfiguration&);
 
-    static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate>, v8::Local<v8::Signature>, v8::PropertyAttribute, const SymbolKeyedMethodConfiguration&);
+    static void installMethod(v8::Isolate*, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface, v8::Local<v8::Signature>, const MethodConfiguration&);
+
+    static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate>, v8::Local<v8::Signature>, const SymbolKeyedMethodConfiguration&);
 
     static v8::Local<v8::Signature> installDOMClassTemplate(v8::Isolate*, v8::Local<v8::FunctionTemplate>, const char* interfaceName, v8::Local<v8::FunctionTemplate> parentClass, size_t fieldCount,
         const AttributeConfiguration*, size_t attributeCount,
         const AccessorConfiguration*, size_t accessorCount,
         const MethodConfiguration*, size_t methodCount);
 
     static v8::Local<v8::FunctionTemplate> domClassTemplate(v8::Isolate*, WrapperTypeInfo*, void (*)(v8::Local<v8::FunctionTemplate>, v8::Isolate*));
 };
 
 } // namespace blink
 
 #endif // V8DOMConfiguration_h