third_party/WebKit/Source/modules/notifications/Notification.idl - Issue 1372373002: bindings: Reduces the custom registration of methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.idl

Issue 1372373002: bindings: Reduces the custom registration of methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h ('K') | « third_party/WebKit/Source/bindings/templates/partial_interface.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/Notification.idl

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.idl b/third_party/WebKit/Source/modules/notifications/Notification.idl

index 8d78f7f5b590ad127f32bf215764a0fd22d84397..38297e74b27acdeda4f67b1ee89abb536e2cc672 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.idl

+++ b/third_party/WebKit/Source/modules/notifications/Notification.idl

@@ -51,7 +51,6 @@ enum NotificationPermission {

] interface Notification : EventTarget {

[CallWith=ExecutionContext, MeasureAs=NotificationPermission] static readonly attribute NotificationPermission permission;

- // TODO(peter): Only expose requestPermission() on the Window object. See https://crbug.com/442139.

[CallWith=ScriptState, Exposed=Window, MeasureAs=NotificationPermissionRequested] static Promise<NotificationPermission> requestPermission(optional NotificationPermissionCallback deprecatedCallback);

[RuntimeEnabled=NotificationExperimental] static readonly attribute unsigned long maxActions;