Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: third_party/WebKit/Source/bindings/templates/partial_interface.cpp

Issue 1372373002: bindings: Reduces the custom registration of methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/partial_interface.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/partial_interface.cpp b/third_party/WebKit/Source/bindings/templates/partial_interface.cpp
index b4489a76153aa8d87a6d4feffe9d1aa97b3206b2..f219897cf26ec5ac981b411a9f207815029ba290 100644
--- a/third_party/WebKit/Source/bindings/templates/partial_interface.cpp
+++ b/third_party/WebKit/Source/bindings/templates/partial_interface.cpp
@@ -2,14 +2,14 @@
{##############################################################################}
-{% block prepare_prototype_object %}
+{% block prepare_prototype_and_interface_object %}
{% from 'interface.cpp' import install_unscopeables with context %}
{% from 'interface.cpp' import install_conditionally_enabled_attributes_on_prototype with context %}
{% from 'methods.cpp' import install_conditionally_enabled_methods
with context %}
-void {{v8_class_or_partial}}::preparePrototypeObject(v8::Isolate* isolate, v8::Local<v8::Object> prototypeObject, v8::Local<v8::FunctionTemplate> interfaceTemplate)
+void {{v8_class_or_partial}}::preparePrototypeAndInterfaceObject(v8::Isolate* isolate, v8::Local<v8::Object> prototypeObject, v8::Local<v8::Function> interfaceObject, v8::Local<v8::FunctionTemplate> interfaceTemplate)
{
- {{v8_class}}::preparePrototypeObject(isolate, prototypeObject, interfaceTemplate);
+ {{v8_class}}::preparePrototypeAndInterfaceObject(isolate, prototypeObject, interfaceObject, interfaceTemplate);
{% if unscopeables %}
{{install_unscopeables() | indent}}
{% endif %}
@@ -31,7 +31,7 @@ void {{v8_class_or_partial}}::initialize()
// Should be invoked from initModules.
{{v8_class}}::updateWrapperTypeInfo(
&{{v8_class_or_partial}}::install{{v8_class}}Template,
- &{{v8_class_or_partial}}::preparePrototypeObject);
+ &{{v8_class_or_partial}}::preparePrototypeAndInterfaceObject);
{% for method in methods %}
{% if method.overloads and method.overloads.has_partial_overloads %}
{{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInterface(&{{cpp_class_or_partial}}V8Internal::{{method.name}}Method);

Powered by Google App Engine
This is Rietveld 408576698