third_party/WebKit/Source/bindings/scripts/v8_methods.py - Issue 1372373002: bindings: Reduces the custom registration of methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 1372373002: bindings: Reduces the custom registration of methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h ('K') | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('k') | third_party/WebKit/Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

index 47a0e052d915a9a5f5976162167372f95dd4bef9..f7d831e102f901021046c8e8eb863783c31e5da4 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

@@ -48,8 +48,6 @@ from v8_utilities import (has_extended_attribute_value, is_unforgeable,

CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES = frozenset([

'DoNotCheckSecurity',

'DoNotCheckSignature',

- 'NotEnumerable',

- 'Unforgeable',

])

@@ -140,8 +138,6 @@ def method_context(interface, method, is_visible=True):

# TODO(yukishiino): Retire has_custom_registration flag. Should be

# replaced with V8DOMConfiguration::PropertyLocationConfiguration.

'has_custom_registration':

- is_static or

- is_unforgeable(interface, method) or

v8_utilities.has_extended_attribute(

method, CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES),

'has_exception_state':