Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h |
| diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h |
| index 04b82884ca20ee9c0004fa85049a51b93dc2b52a..e4c44e62260695ecb5b8fdd66ea8a5b2f2801fc1 100644 |
| --- a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h |
| +++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h |
| @@ -74,8 +74,8 @@ public: |
| v8::AccessorNameGetterCallback getterForMainWorld; |
| v8::AccessorNameSetterCallback setterForMainWorld; |
| const WrapperTypeInfo* data; |
| - v8::AccessControl settings; |
| - v8::PropertyAttribute attribute; |
| + unsigned settings : 8; // v8::AccessControl |
|
haraken
2015/10/02 09:33:40
4 bit looks enough though.
Yuki
2015/10/02 10:36:48
Yes, that's true. But v8.h is out of our (direct)
|
| + unsigned attribute : 8; // v8::PropertyAttribute |
| unsigned exposeConfiguration : 1; // ExposeConfiguration |
| unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration |
| unsigned holderCheckConfiguration : 1; // HolderCheckConfiguration |
| @@ -96,8 +96,8 @@ public: |
| v8::FunctionCallback getterForMainWorld; |
| v8::FunctionCallback setterForMainWorld; |
| const WrapperTypeInfo* data; |
| - v8::AccessControl settings; |
| - v8::PropertyAttribute attribute; |
| + unsigned settings : 8; // v8::AccessControl |
| + unsigned attribute : 8; // v8::PropertyAttribute |
| unsigned exposeConfiguration : 1; // ExposeConfiguration |
| unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration |
| unsigned holderCheckConfiguration : 1; // HolderCheckConfiguration |
| @@ -160,6 +160,7 @@ public: |
| v8::FunctionCallback callback; |
| v8::FunctionCallback callbackForMainWorld; |
| int length; |
| + unsigned attribute : 8; // v8::PropertyAttribute |
| unsigned exposeConfiguration : 1; // ExposeConfiguration |
| unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration |
| }; |
| @@ -177,15 +178,18 @@ public: |
| v8::FunctionCallback callback; |
| // SymbolKeyedMethodConfiguration doesn't support per-world bindings. |
| int length; |
| + unsigned attribute : 8; // v8::PropertyAttribute |
| unsigned exposeConfiguration : 1; // ExposeConfiguration |
| unsigned propertyLocationConfiguration : 3; // PropertyLocationConfiguration |
| }; |
| - static void installMethods(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration*, size_t methodCount); |
| + static void installMethods(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, const MethodConfiguration*, size_t methodCount); |
| - static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, v8::PropertyAttribute, const MethodConfiguration&); |
| + static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate> instanceTemplate, v8::Local<v8::ObjectTemplate> prototypeTemplate, v8::Local<v8::FunctionTemplate> interfaceTemplate, v8::Local<v8::Signature>, const MethodConfiguration&); |
| - static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate>, v8::Local<v8::Signature>, v8::PropertyAttribute, const SymbolKeyedMethodConfiguration&); |
| + static void installMethod(v8::Isolate*, v8::Local<v8::Object> instance, v8::Local<v8::Object> prototype, v8::Local<v8::Function> interface, v8::Local<v8::Signature>, const MethodConfiguration&); |
| + |
| + static void installMethod(v8::Isolate*, v8::Local<v8::ObjectTemplate>, v8::Local<v8::Signature>, const SymbolKeyedMethodConfiguration&); |
| static v8::Local<v8::Signature> installDOMClassTemplate(v8::Isolate*, v8::Local<v8::FunctionTemplate>, const char* interfaceName, v8::Local<v8::FunctionTemplate> parentClass, size_t fieldCount, |
| const AttributeConfiguration*, size_t attributeCount, |