chromium_tests: fix crash in deapply_patch on got_webkit_revision

chromium_tests: fix crash in deapply_patch on got_webkit_revision

Traceback (most recent call last):
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/run.py", line 873, in run
    steps_function, api._engine.properties, prop_defs, api=api)
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 431, in invoke_with_properties
    return callable_obj(*props, **additional_args)
  File "/b/build/scripts/slave/recipes/chromium_trybot.py", line 832, in RunSteps
    return _RunStepsInternal(api)
  File "/b/build/scripts/slave/recipes/chromium_trybot.py", line 806, in _RunStepsInternal
    override_bot_type='builder_tester')
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 217, in _inner
    return func(*a, **kw)
  File "/b/build/scripts/slave/recipe_modules/chromium_tests/api.py", line 375, in compile_specific_targets
    self.transient_check(update_step, lambda transform_name:
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 217, in _inner
    return func(*a, **kw)
  File "/b/build/scripts/slave/recipe_modules/chromium_tests/api.py", line 327, in transient_check
    self.deapply_patch(update_step)
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 217, in _inner
    return func(*a, **kw)
  File "/b/build/scripts/slave/recipe_modules/chromium_tests/api.py", line 554, in deapply_patch
    bot_update_json['properties'][revision])
KeyError: 'got_webkit_revision'

BUG=431482
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296847

[Paweł Hajdan Jr., 2015-09-23 16:59:25]

phajdan.jr@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-09-23 17:04:09]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-09-23 17:04:11]

lgtm

[Primiano Tucci (use gerrit), 2015-09-23 17:07:05]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-09-23 17:07:07]

LGTM w/ 1 question

https://codereview.chromium.org/1365683002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/gclient/config.py (right):

https://codereview.chromium.org/1365683002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/gclient/config.py:238: 'webkit',
parent_got_revision='parent_got_webkit_revision')
shouldn't we remove this as well?

[commit-bot: I haz the power, 2015-09-23 17:07:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1365683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1365683002/1

[commit-bot: I haz the power, 2015-09-23 17:18:44]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296847

[Michael Achenbach, 2015-09-23 17:20:42]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2015-09-23 17:20:45]

https://codereview.chromium.org/1365683002/diff/1/scripts/slave/recipes/blink...
File scripts/slave/recipes/blink_trybot.py (right):

https://codereview.chromium.org/1365683002/diff/1/scripts/slave/recipes/blink...
scripts/slave/recipes/blink_trybot.py:152: def deapply_patch_fn(_failing_steps):
 # pragma: no cover
Huh, why no coverage now? Is it not covered anymore? How about a test?