Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Side by Side Diff: scripts/slave/recipes/run_presubmit.py

Issue 1365683002: chromium_tests: fix crash in deapply_patch on got_webkit_revision (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'bot_update', 6 'bot_update',
7 'gclient', 7 'gclient',
8 'git', 8 'git',
9 'json', 9 'json',
10 'path', 10 'path',
11 'properties', 11 'properties',
12 'python', 12 'python',
13 'tryserver', 13 'tryserver',
14 'rietveld', 14 'rietveld',
15 'v8', 15 'v8',
16 'webrtc', 16 'webrtc',
17 ] 17 ]
18 18
19 19
20 def _RunStepsInternal(api): 20 def _RunStepsInternal(api):
21 root = api.rietveld.calculate_issue_root(extra_patch_project_roots={'v8': []}) 21 root = api.rietveld.calculate_issue_root(extra_patch_project_roots={'v8': []})
22 22
23 repo_name = api.properties['repo_name'] 23 repo_name = api.properties['repo_name']
24 codereview_auth = api.properties.get('codereview_auth', False) 24 codereview_auth = api.properties.get('codereview_auth', False)
25 force_checkout = api.properties.get('force_checkout', False) 25 force_checkout = api.properties.get('force_checkout', False)
26 26
27 api.gclient.set_config(repo_name) 27 api.gclient.set_config(repo_name)
28 if api.properties.get('patch_project') == 'blink':
29 api.gclient.apply_config('blink', optional=True)
30 28
31 bot_update_step = api.bot_update.ensure_checkout( 29 bot_update_step = api.bot_update.ensure_checkout(
32 force=force_checkout, patch_project_roots={'v8': []}, 30 force=force_checkout, patch_project_roots={'v8': []},
33 patch_oauth2=codereview_auth) 31 patch_oauth2=codereview_auth)
34 relative_root = '%s/%s' % (api.gclient.c.solutions[0].name, root) 32 relative_root = '%s/%s' % (api.gclient.c.solutions[0].name, root)
35 relative_root = relative_root.strip('/') 33 relative_root = relative_root.strip('/')
36 got_revision_property = api.gclient.c.got_revision_mapping[relative_root] 34 got_revision_property = api.gclient.c.got_revision_mapping[relative_root]
37 upstream = bot_update_step.json.output['properties'].get( 35 upstream = bot_update_step.json.output['properties'].get(
38 got_revision_property) 36 got_revision_property)
39 if (not upstream or 37 if (not upstream or
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 87
90 88
91 def RunSteps(api): 89 def RunSteps(api):
92 with api.tryserver.set_failure_hash(): 90 with api.tryserver.set_failure_hash():
93 return _RunStepsInternal(api) 91 return _RunStepsInternal(api)
94 92
95 93
96 def GenTests(api): 94 def GenTests(api):
97 # TODO(machenbach): This uses the same tryserver for all repos, which doesn't 95 # TODO(machenbach): This uses the same tryserver for all repos, which doesn't
98 # reflect reality (cosmetical problem only). 96 # reflect reality (cosmetical problem only).
99 for repo_name in ['blink', 'chromium', 'v8', 'nacl', 'naclports', 'gyp', 97 for repo_name in ['chromium', 'v8', 'nacl', 'naclports', 'gyp',
100 'build', 'build_internal', 'build_internal_scripts_slave', 98 'build', 'build_internal', 'build_internal_scripts_slave',
101 'depot_tools', 'skia', 'chrome_golo', 'webrtc', 'catapult']: 99 'depot_tools', 'skia', 'chrome_golo', 'webrtc', 'catapult']:
102 yield ( 100 yield (
103 api.test(repo_name) + 101 api.test(repo_name) +
104 api.properties.tryserver( 102 api.properties.tryserver(
105 mastername='tryserver.chromium.linux', 103 mastername='tryserver.chromium.linux',
106 buildername='%s_presubmit' % repo_name, 104 buildername='%s_presubmit' % repo_name,
107 repo_name=repo_name, 105 repo_name=repo_name,
108 patch_project=repo_name) + 106 patch_project=repo_name) +
109 api.step_data('presubmit', api.json.output([['%s_presubmit' % repo_name, 107 api.step_data('presubmit', api.json.output([['%s_presubmit' % repo_name,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 api.test('recipes-py') + 147 api.test('recipes-py') +
150 api.properties.tryserver( 148 api.properties.tryserver(
151 mastername='tryserver.infra', 149 mastername='tryserver.infra',
152 buildername='infra_presubmit', 150 buildername='infra_presubmit',
153 repo_name='recipes_py', 151 repo_name='recipes_py',
154 patch_project='recipes-py', 152 patch_project='recipes-py',
155 runhooks=True) + 153 runhooks=True) +
156 api.step_data('presubmit', api.json.output([['infra_presubmit', 154 api.step_data('presubmit', api.json.output([['infra_presubmit',
157 ['compile']]])) 155 ['compile']]]))
158 ) 156 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698