scripts/slave/recipes/run_presubmit.py - Issue 1365683002: chromium_tests: fix crash in deapply_patch on got_webkit_revision

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/run_presubmit.py

Issue 1365683002: chromium_tests: fix crash in deapply_patch on got_webkit_revision (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/blink_trybot.py ('K') | « scripts/slave/recipes/perf/telemetry_harness_upload.expected/basic.json ('k') | scripts/slave/recipes/run_presubmit.expected/blink.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/run_presubmit.py

diff --git a/scripts/slave/recipes/run_presubmit.py b/scripts/slave/recipes/run_presubmit.py

index 8a4a93c504d2fe02c4cbe25724e54ddb7a9dae89..21220ab164b3066e484b810a329be999965de7d0 100644

--- a/scripts/slave/recipes/run_presubmit.py

+++ b/scripts/slave/recipes/run_presubmit.py

@@ -25,8 +25,6 @@ def _RunStepsInternal(api):

force_checkout = api.properties.get('force_checkout', False)

api.gclient.set_config(repo_name)

- if api.properties.get('patch_project') == 'blink':

- api.gclient.apply_config('blink', optional=True)

bot_update_step = api.bot_update.ensure_checkout(

force=force_checkout, patch_project_roots={'v8': []},

@@ -96,7 +94,7 @@ def RunSteps(api):

def GenTests(api):

# TODO(machenbach): This uses the same tryserver for all repos, which doesn't

# reflect reality (cosmetical problem only).

- for repo_name in ['blink', 'chromium', 'v8', 'nacl', 'naclports', 'gyp',

+ for repo_name in ['chromium', 'v8', 'nacl', 'naclports', 'gyp',

'build', 'build_internal', 'build_internal_scripts_slave',

'depot_tools', 'skia', 'chrome_golo', 'webrtc', 'catapult']:

yield (