scripts/slave/recipes/blink_trybot.py - Issue 1365683002: chromium_tests: fix crash in deapply_patch on got_webkit_revision

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/blink_trybot.py

Issue 1365683002: chromium_tests: fix crash in deapply_patch on got_webkit_revision (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/gclient/config.py ('K') | « scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json ('k') | scripts/slave/recipes/blink_trybot.expected/blink_heap_unittests_failure.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/blink_trybot.py

diff --git a/scripts/slave/recipes/blink_trybot.py b/scripts/slave/recipes/blink_trybot.py

index 01b470d54b0f428046905c4af8da329e9e6f9443..cc3ff134cc136cbfd10bb83cb5207f4d75077e2f 100644

--- a/scripts/slave/recipes/blink_trybot.py

+++ b/scripts/slave/recipes/blink_trybot.py

@@ -149,7 +149,7 @@ def _RunStepsInternal(api):

"import sys; sys.exit(1)")

raise exception

- def deapply_patch_fn(_failing_steps):

+ def deapply_patch_fn(_failing_steps): # pragma: no cover

Michael Achenbach 2015/09/23 17:20:45 Huh, why no coverage now? Is it not covered anymor

properties = bot_update_step.json.output['properties']

# Use the got_cr_revision property if available. In component-driven

# builds it will hold the chromium revision (while got_revision will