Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: scripts/slave/recipes/blink_trybot.py

Issue 1365683002: chromium_tests: fix crash in deapply_patch on got_webkit_revision (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 6
7 DEPS = [ 7 DEPS = [
8 'bot_update', 8 'bot_update',
9 'chromium', 9 'chromium',
10 'chromium_tests', 10 'chromium_tests',
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 except api.step.StepFailure as f: 142 except api.step.StepFailure as f:
143 failed = True 143 failed = True
144 exception = f 144 exception = f
145 145
146 if failed: 146 if failed:
147 api.python.inline( 147 api.python.inline(
148 'Aborting due to failed build state', 148 'Aborting due to failed build state',
149 "import sys; sys.exit(1)") 149 "import sys; sys.exit(1)")
150 raise exception 150 raise exception
151 151
152 def deapply_patch_fn(_failing_steps): 152 def deapply_patch_fn(_failing_steps): # pragma: no cover
Michael Achenbach 2015/09/23 17:20:45 Huh, why no coverage now? Is it not covered anymor
153 properties = bot_update_step.json.output['properties'] 153 properties = bot_update_step.json.output['properties']
154 # Use the got_cr_revision property if available. In component-driven 154 # Use the got_cr_revision property if available. In component-driven
155 # builds it will hold the chromium revision (while got_revision will 155 # builds it will hold the chromium revision (while got_revision will
156 # hold the revision of the component, e.g. v8). 156 # hold the revision of the component, e.g. v8).
157 api.gclient.c.revisions['src'] = str( 157 api.gclient.c.revisions['src'] = str(
158 properties.get('got_cr_revision', properties['got_revision'])) 158 properties.get('got_cr_revision', properties['got_revision']))
159 api.gclient.c.revisions['src/third_party/WebKit'] = str( 159 api.gclient.c.revisions['src/third_party/WebKit'] = str(
160 properties['got_webkit_revision']) 160 properties['got_webkit_revision'])
161 161
162 api.bot_update.ensure_checkout(patch=False, force=True) 162 api.bot_update.ensure_checkout(patch=False, force=True)
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 api.override_step_data(with_patch, canned_test(passing=True)) 288 api.override_step_data(with_patch, canned_test(passing=True))
289 ) 289 )
290 290
291 yield ( 291 yield (
292 api.test('use_v8_patch_on_blink_trybot') + 292 api.test('use_v8_patch_on_blink_trybot') +
293 properties(buildername='v8_linux_layout_dbg', 293 properties(buildername='v8_linux_layout_dbg',
294 mastername='tryserver.v8', 294 mastername='tryserver.v8',
295 patch_project='v8') + 295 patch_project='v8') +
296 api.platform.name('mac') 296 api.platform.name('mac')
297 ) 297 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698