Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
vsevik, pfeldman, eseidel
CC:
blink-reviews, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Update inspector classes to use OVERRIDE / FINAL when needed Update inspector classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=eseidel, pfeldman@chromium.org, vsevik BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164942

Patch Set 1 #

Patch Set 2 : No change under web/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -490 lines) Patch
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 21 chunks +32 lines, -32 lines 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModule.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 17 chunks +33 lines, -33 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 2 chunks +43 lines, -43 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 4 chunks +15 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 6 chunks +48 lines, -48 lines 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.h View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHistory.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorIndexedDBAgent.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 3 chunks +39 lines, -39 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 2 chunks +17 lines, -17 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/inspector/WorkerConsoleAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/WorkerRuntimeAgent.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-11 22:41:40 UTC) #1
eseidel
lgtm
6 years, 11 months ago (2014-01-12 00:58:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135703002/70001
6 years, 11 months ago (2014-01-12 00:58:32 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 00:49:29 UTC) #4
Message was sent while issue was closed. 
Change committed as 164942

Powered by Google App Engine
This is Rietveld 408576698