Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/core/inspector/InspectorProfilerAgent.h

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No change under web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorPageAgent.h ('k') | Source/core/inspector/InspectorResourceAgent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 class InjectedScriptManager; 43 class InjectedScriptManager;
44 class InspectorFrontend; 44 class InspectorFrontend;
45 class InspectorOverlay; 45 class InspectorOverlay;
46 class InstrumentingAgents; 46 class InstrumentingAgents;
47 class ScriptCallStack; 47 class ScriptCallStack;
48 class ScriptProfile; 48 class ScriptProfile;
49 class ScriptState; 49 class ScriptState;
50 50
51 typedef String ErrorString; 51 typedef String ErrorString;
52 52
53 class InspectorProfilerAgent : public InspectorBaseAgent<InspectorProfilerAgent> , public InspectorBackendDispatcher::ProfilerCommandHandler { 53 class InspectorProfilerAgent FINAL : public InspectorBaseAgent<InspectorProfiler Agent>, public InspectorBackendDispatcher::ProfilerCommandHandler {
54 WTF_MAKE_NONCOPYABLE(InspectorProfilerAgent); WTF_MAKE_FAST_ALLOCATED; 54 WTF_MAKE_NONCOPYABLE(InspectorProfilerAgent); WTF_MAKE_FAST_ALLOCATED;
55 public: 55 public:
56 static PassOwnPtr<InspectorProfilerAgent> create(InstrumentingAgents*, Inspe ctorCompositeState*, InjectedScriptManager*, InspectorOverlay*); 56 static PassOwnPtr<InspectorProfilerAgent> create(InstrumentingAgents*, Inspe ctorCompositeState*, InjectedScriptManager*, InspectorOverlay*);
57 virtual ~InspectorProfilerAgent(); 57 virtual ~InspectorProfilerAgent();
58 58
59 void consoleProfile(const String& title, ScriptState*); 59 void consoleProfile(const String& title, ScriptState*);
60 void consoleProfileEnd(const String& title); 60 void consoleProfileEnd(const String& title);
61 61
62 virtual void enable(ErrorString*); 62 virtual void enable(ErrorString*) OVERRIDE;
63 virtual void disable(ErrorString*); 63 virtual void disable(ErrorString*) OVERRIDE;
64 virtual void setSamplingInterval(ErrorString*, int); 64 virtual void setSamplingInterval(ErrorString*, int) OVERRIDE;
65 virtual void start(ErrorString*); 65 virtual void start(ErrorString*) OVERRIDE;
66 virtual void stop(ErrorString*, RefPtr<TypeBuilder::Profiler::CPUProfile>&); 66 virtual void stop(ErrorString*, RefPtr<TypeBuilder::Profiler::CPUProfile>&) OVERRIDE;
67 67
68 virtual void setFrontend(InspectorFrontend*); 68 virtual void setFrontend(InspectorFrontend*) OVERRIDE;
69 virtual void clearFrontend(); 69 virtual void clearFrontend() OVERRIDE;
70 virtual void restore(); 70 virtual void restore() OVERRIDE;
71 71
72 void willProcessTask(); 72 void willProcessTask();
73 void didProcessTask(); 73 void didProcessTask();
74 void willEnterNestedRunLoop(); 74 void willEnterNestedRunLoop();
75 void didLeaveNestedRunLoop(); 75 void didLeaveNestedRunLoop();
76 76
77 private: 77 private:
78 InspectorProfilerAgent(InstrumentingAgents*, InspectorCompositeState*, Injec tedScriptManager*, InspectorOverlay*); 78 InspectorProfilerAgent(InstrumentingAgents*, InspectorCompositeState*, Injec tedScriptManager*, InspectorOverlay*);
79 bool enabled(); 79 bool enabled();
80 void doEnable(); 80 void doEnable();
(...skipping 13 matching lines...) Expand all
94 InspectorOverlay* m_overlay; 94 InspectorOverlay* m_overlay;
95 95
96 void idleStarted(); 96 void idleStarted();
97 void idleFinished(); 97 void idleFinished();
98 }; 98 };
99 99
100 } // namespace WebCore 100 } // namespace WebCore
101 101
102 102
103 #endif // !defined(InspectorProfilerAgent_h) 103 #endif // !defined(InspectorProfilerAgent_h)
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorPageAgent.h ('k') | Source/core/inspector/InspectorResourceAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698