Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No change under web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 // so this method will never be called after m_heapProfilerAgent has been de stroyed. 137 // so this method will never be called after m_heapProfilerAgent has been de stroyed.
138 m_heapProfilerAgent->requestHeapStatsUpdate(); 138 m_heapProfilerAgent->requestHeapStatsUpdate();
139 } 139 }
140 140
141 void InspectorHeapProfilerAgent::HeapStatsUpdateTask::startTimer() 141 void InspectorHeapProfilerAgent::HeapStatsUpdateTask::startTimer()
142 { 142 {
143 ASSERT(!m_timer.isActive()); 143 ASSERT(!m_timer.isActive());
144 m_timer.startRepeating(0.05); 144 m_timer.startRepeating(0.05);
145 } 145 }
146 146
147 class InspectorHeapProfilerAgent::HeapStatsStream : public ScriptProfiler::Outpu tStream { 147 class InspectorHeapProfilerAgent::HeapStatsStream FINAL : public ScriptProfiler: :OutputStream {
148 public: 148 public:
149 HeapStatsStream(InspectorHeapProfilerAgent* heapProfilerAgent) 149 HeapStatsStream(InspectorHeapProfilerAgent* heapProfilerAgent)
150 : m_heapProfilerAgent(heapProfilerAgent) 150 : m_heapProfilerAgent(heapProfilerAgent)
151 { 151 {
152 } 152 }
153 153
154 virtual void write(const uint32_t* chunk, const int size) OVERRIDE 154 virtual void write(const uint32_t* chunk, const int size) OVERRIDE
155 { 155 {
156 ASSERT(chunk); 156 ASSERT(chunk);
157 ASSERT(size > 0); 157 ASSERT(size > 0);
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 if (value.hasNoValue() || value.isUndefined()) { 321 if (value.hasNoValue() || value.isUndefined()) {
322 *errorString = "Object with given id not found"; 322 *errorString = "Object with given id not found";
323 return; 323 return;
324 } 324 }
325 unsigned id = ScriptProfiler::getHeapObjectId(value); 325 unsigned id = ScriptProfiler::getHeapObjectId(value);
326 *heapSnapshotObjectId = String::number(id); 326 *heapSnapshotObjectId = String::number(id);
327 } 327 }
328 328
329 } // namespace WebCore 329 } // namespace WebCore
330 330
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorHeapProfilerAgent.h ('k') | Source/core/inspector/InspectorHistory.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698