Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No change under web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.h ('k') | Source/core/inspector/InspectorDOMStorageAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/Source/core/inspector/InspectorDOMDebuggerAgent.h b/Source/core/inspector/InspectorDOMDebuggerAgent.h
index 0c61a991cd8898445cd78f43c41ef42fbe0de3d1..ccdf5f9d9255f43972514673197497cf18f38c7c 100644
--- a/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -53,7 +53,7 @@ class Node;
typedef String ErrorString;
-class InspectorDOMDebuggerAgent : public InspectorBaseAgent<InspectorDOMDebuggerAgent>, public InspectorDebuggerAgent::Listener, public InspectorBackendDispatcher::DOMDebuggerCommandHandler {
+class InspectorDOMDebuggerAgent FINAL : public InspectorBaseAgent<InspectorDOMDebuggerAgent>, public InspectorDebuggerAgent::Listener, public InspectorBackendDispatcher::DOMDebuggerCommandHandler {
WTF_MAKE_NONCOPYABLE(InspectorDOMDebuggerAgent);
public:
static PassOwnPtr<InspectorDOMDebuggerAgent> create(InstrumentingAgents*, InspectorCompositeState*, InspectorDOMAgent*, InspectorDebuggerAgent*);
@@ -61,14 +61,14 @@ public:
virtual ~InspectorDOMDebuggerAgent();
// DOMDebugger API for InspectorFrontend
- virtual void setXHRBreakpoint(ErrorString*, const String& url);
- virtual void removeXHRBreakpoint(ErrorString*, const String& url);
- virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName);
- virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName);
- virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName);
- virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName);
- virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type);
- virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type);
+ virtual void setXHRBreakpoint(ErrorString*, const String& url) OVERRIDE;
+ virtual void removeXHRBreakpoint(ErrorString*, const String& url) OVERRIDE;
+ virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName) OVERRIDE;
+ virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName) OVERRIDE;
+ virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName) OVERRIDE;
+ virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) OVERRIDE;
+ virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type) OVERRIDE;
+ virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type) OVERRIDE;
// InspectorInstrumentation API
void willInsertDOMNode(Node* parent);
@@ -92,8 +92,8 @@ public:
void didProcessTask();
- virtual void clearFrontend();
- virtual void discardAgent();
+ virtual void clearFrontend() OVERRIDE;
+ virtual void discardAgent() OVERRIDE;
private:
InspectorDOMDebuggerAgent(InstrumentingAgents*, InspectorCompositeState*, InspectorDOMAgent*, InspectorDebuggerAgent*);
@@ -102,10 +102,10 @@ private:
PassRefPtr<JSONObject> preparePauseOnNativeEventData(bool isDOMEvent, const String& eventName);
// InspectorDebuggerAgent::Listener implementation.
- virtual void debuggerWasEnabled();
- virtual void debuggerWasDisabled();
- virtual void stepInto();
- virtual void didPause();
+ virtual void debuggerWasEnabled() OVERRIDE;
+ virtual void debuggerWasDisabled() OVERRIDE;
+ virtual void stepInto() OVERRIDE;
+ virtual void didPause() OVERRIDE;
void disable();
void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, JSONObject* description);
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.h ('k') | Source/core/inspector/InspectorDOMStorageAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698