Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: Source/core/inspector/InspectorApplicationCacheAgent.h

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No change under web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorAgent.h ('k') | Source/core/inspector/InspectorBaseAgent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 22 matching lines...) Expand all
33 33
34 namespace WebCore { 34 namespace WebCore {
35 35
36 class Frame; 36 class Frame;
37 class InspectorFrontend; 37 class InspectorFrontend;
38 class InspectorPageAgent; 38 class InspectorPageAgent;
39 class InstrumentingAgents; 39 class InstrumentingAgents;
40 40
41 typedef String ErrorString; 41 typedef String ErrorString;
42 42
43 class InspectorApplicationCacheAgent : public InspectorBaseAgent<InspectorApplic ationCacheAgent>, public InspectorBackendDispatcher::ApplicationCacheCommandHand ler { 43 class InspectorApplicationCacheAgent FINAL : public InspectorBaseAgent<Inspector ApplicationCacheAgent>, public InspectorBackendDispatcher::ApplicationCacheComma ndHandler {
44 WTF_MAKE_NONCOPYABLE(InspectorApplicationCacheAgent); WTF_MAKE_FAST_ALLOCATE D; 44 WTF_MAKE_NONCOPYABLE(InspectorApplicationCacheAgent); WTF_MAKE_FAST_ALLOCATE D;
45 public: 45 public:
46 static PassOwnPtr<InspectorApplicationCacheAgent> create(InstrumentingAgents * instrumentingAgents, InspectorCompositeState* state, InspectorPageAgent* pageA gent) 46 static PassOwnPtr<InspectorApplicationCacheAgent> create(InstrumentingAgents * instrumentingAgents, InspectorCompositeState* state, InspectorPageAgent* pageA gent)
47 { 47 {
48 return adoptPtr(new InspectorApplicationCacheAgent(instrumentingAgents, state, pageAgent)); 48 return adoptPtr(new InspectorApplicationCacheAgent(instrumentingAgents, state, pageAgent));
49 } 49 }
50 ~InspectorApplicationCacheAgent() { } 50 virtual ~InspectorApplicationCacheAgent() { }
51 51
52 // InspectorBaseAgent 52 // InspectorBaseAgent
53 virtual void setFrontend(InspectorFrontend*); 53 virtual void setFrontend(InspectorFrontend*) OVERRIDE;
54 virtual void clearFrontend(); 54 virtual void clearFrontend() OVERRIDE;
55 virtual void restore(); 55 virtual void restore() OVERRIDE;
56 56
57 // InspectorInstrumentation API 57 // InspectorInstrumentation API
58 void updateApplicationCacheStatus(Frame*); 58 void updateApplicationCacheStatus(Frame*);
59 void networkStateChanged(bool online); 59 void networkStateChanged(bool online);
60 60
61 // ApplicationCache API for InspectorFrontend 61 // ApplicationCache API for InspectorFrontend
62 virtual void enable(ErrorString*); 62 virtual void enable(ErrorString*) OVERRIDE;
63 virtual void getFramesWithManifests(ErrorString*, RefPtr<TypeBuilder::Array< TypeBuilder::ApplicationCache::FrameWithManifest> >& result); 63 virtual void getFramesWithManifests(ErrorString*, RefPtr<TypeBuilder::Array< TypeBuilder::ApplicationCache::FrameWithManifest> >& result) OVERRIDE;
64 virtual void getManifestForFrame(ErrorString*, const String& frameId, String * manifestURL); 64 virtual void getManifestForFrame(ErrorString*, const String& frameId, String * manifestURL) OVERRIDE;
65 virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId , RefPtr<TypeBuilder::ApplicationCache::ApplicationCache>&); 65 virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId , RefPtr<TypeBuilder::ApplicationCache::ApplicationCache>&) OVERRIDE;
66 66
67 private: 67 private:
68 InspectorApplicationCacheAgent(InstrumentingAgents*, InspectorCompositeState *, InspectorPageAgent*); 68 InspectorApplicationCacheAgent(InstrumentingAgents*, InspectorCompositeState *, InspectorPageAgent*);
69 PassRefPtr<TypeBuilder::ApplicationCache::ApplicationCache> buildObjectForAp plicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationC acheHost::CacheInfo&); 69 PassRefPtr<TypeBuilder::ApplicationCache::ApplicationCache> buildObjectForAp plicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationC acheHost::CacheInfo&);
70 PassRefPtr<TypeBuilder::Array<TypeBuilder::ApplicationCache::ApplicationCach eResource> > buildArrayForApplicationCacheResources(const ApplicationCacheHost:: ResourceInfoList&); 70 PassRefPtr<TypeBuilder::Array<TypeBuilder::ApplicationCache::ApplicationCach eResource> > buildArrayForApplicationCacheResources(const ApplicationCacheHost:: ResourceInfoList&);
71 PassRefPtr<TypeBuilder::ApplicationCache::ApplicationCacheResource> buildObj ectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo&); 71 PassRefPtr<TypeBuilder::ApplicationCache::ApplicationCacheResource> buildObj ectForApplicationCacheResource(const ApplicationCacheHost::ResourceInfo&);
72 72
73 DocumentLoader* assertFrameWithDocumentLoader(ErrorString*, String frameId); 73 DocumentLoader* assertFrameWithDocumentLoader(ErrorString*, String frameId);
74 74
75 InspectorPageAgent* m_pageAgent; 75 InspectorPageAgent* m_pageAgent;
76 InspectorFrontend::ApplicationCache* m_frontend; 76 InspectorFrontend::ApplicationCache* m_frontend;
77 }; 77 };
78 78
79 } // namespace WebCore 79 } // namespace WebCore
80 80
81 #endif // InspectorApplicationCacheAgent_h 81 #endif // InspectorApplicationCacheAgent_h
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorAgent.h ('k') | Source/core/inspector/InspectorBaseAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698