Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/core/inspector/PageDebuggerAgent.h

Issue 135703002: Update inspector classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No change under web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/PageConsoleAgent.cpp ('k') | Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class DocumentLoader; 40 class DocumentLoader;
41 class InspectorOverlay; 41 class InspectorOverlay;
42 class InspectorPageAgent; 42 class InspectorPageAgent;
43 class Page; 43 class Page;
44 class PageScriptDebugServer; 44 class PageScriptDebugServer;
45 class ScriptSourceCode; 45 class ScriptSourceCode;
46 46
47 class PageDebuggerAgent : 47 class PageDebuggerAgent FINAL :
48 public InspectorDebuggerAgent, 48 public InspectorDebuggerAgent,
49 public InspectorOverlayHost::Listener { 49 public InspectorOverlayHost::Listener {
50 WTF_MAKE_NONCOPYABLE(PageDebuggerAgent); 50 WTF_MAKE_NONCOPYABLE(PageDebuggerAgent);
51 WTF_MAKE_FAST_ALLOCATED; 51 WTF_MAKE_FAST_ALLOCATED;
52 public: 52 public:
53 static PassOwnPtr<PageDebuggerAgent> create(InstrumentingAgents*, InspectorC ompositeState*, PageScriptDebugServer*, InspectorPageAgent*, InjectedScriptManag er*, InspectorOverlay*); 53 static PassOwnPtr<PageDebuggerAgent> create(InstrumentingAgents*, InspectorC ompositeState*, PageScriptDebugServer*, InspectorPageAgent*, InjectedScriptManag er*, InspectorOverlay*);
54 virtual ~PageDebuggerAgent(); 54 virtual ~PageDebuggerAgent();
55 55
56 void didClearWindowObjectInWorld(Frame*, DOMWrapperWorld*); 56 void didClearWindowObjectInWorld(Frame*, DOMWrapperWorld*);
57 String preprocessEventListener(Frame*, const String& source, const String& u rl, const String& functionName); 57 String preprocessEventListener(Frame*, const String& source, const String& u rl, const String& functionName);
58 PassOwnPtr<ScriptSourceCode> preprocess(Frame*, const ScriptSourceCode&); 58 PassOwnPtr<ScriptSourceCode> preprocess(Frame*, const ScriptSourceCode&);
59 void didCommitLoad(Frame*, DocumentLoader*); 59 void didCommitLoad(Frame*, DocumentLoader*);
60 60
61 protected: 61 protected:
62 virtual void enable(); 62 virtual void enable() OVERRIDE;
63 virtual void disable(); 63 virtual void disable() OVERRIDE;
64 64
65 private: 65 private:
66 virtual void startListeningScriptDebugServer(); 66 virtual void startListeningScriptDebugServer() OVERRIDE;
67 virtual void stopListeningScriptDebugServer(); 67 virtual void stopListeningScriptDebugServer() OVERRIDE;
68 virtual PageScriptDebugServer& scriptDebugServer(); 68 virtual PageScriptDebugServer& scriptDebugServer() OVERRIDE;
69 virtual void muteConsole(); 69 virtual void muteConsole() OVERRIDE;
70 virtual void unmuteConsole(); 70 virtual void unmuteConsole() OVERRIDE;
71 71
72 // InspectorOverlayHost::Listener implementation. 72 // InspectorOverlayHost::Listener implementation.
73 virtual void overlayResumed(); 73 virtual void overlayResumed() OVERRIDE;
74 virtual void overlaySteppedOver(); 74 virtual void overlaySteppedOver() OVERRIDE;
75 75
76 virtual InjectedScript injectedScriptForEval(ErrorString*, const int* execut ionContextId); 76 virtual InjectedScript injectedScriptForEval(ErrorString*, const int* execut ionContextId) OVERRIDE;
77 virtual void setOverlayMessage(ErrorString*, const String*); 77 virtual void setOverlayMessage(ErrorString*, const String*) OVERRIDE;
78 78
79 PageDebuggerAgent(InstrumentingAgents*, InspectorCompositeState*, PageScript DebugServer*, InspectorPageAgent*, InjectedScriptManager*, InspectorOverlay*); 79 PageDebuggerAgent(InstrumentingAgents*, InspectorCompositeState*, PageScript DebugServer*, InspectorPageAgent*, InjectedScriptManager*, InspectorOverlay*);
80 PageScriptDebugServer* m_pageScriptDebugServer; 80 PageScriptDebugServer* m_pageScriptDebugServer;
81 InspectorPageAgent* m_pageAgent; 81 InspectorPageAgent* m_pageAgent;
82 InspectorOverlay* m_overlay; 82 InspectorOverlay* m_overlay;
83 }; 83 };
84 84
85 } // namespace WebCore 85 } // namespace WebCore
86 86
87 87
88 #endif // !defined(PageDebuggerAgent_h) 88 #endif // !defined(PageDebuggerAgent_h)
OLDNEW
« no previous file with comments | « Source/core/inspector/PageConsoleAgent.cpp ('k') | Source/core/inspector/PageRuntimeAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698