Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1356913002: [turbofan] Add support for reinterpreting integers as floating point and vice versa. (Closed)

Created:
5 years, 3 months ago by titzer
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for reinterpreting integers as floating point and vice versa. R=bmeurer@chromium.org Committed: https://crrev.com/c610a22231212b12055c294f55b8f3942127580b Cr-Commit-Position: refs/heads/master@{#30849}

Patch Set 1 #

Patch Set 2 : Rename ReinterpretAs to BitcastTo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -8 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 chunks +25 lines, -6 lines 0 comments Download
M src/compiler/opcodes.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
titzer
5 years, 3 months ago (2015-09-18 14:56:55 UTC) #1
Benedikt Meurer
Can you move the instruction codes to the ARCH_OPCODE_LIST in instruction-codes.h, because they are available ...
5 years, 3 months ago (2015-09-19 16:55:38 UTC) #2
titzer
On 2015/09/19 16:55:38, Benedikt Meurer wrote: > Can you move the instruction codes to the ...
5 years, 3 months ago (2015-09-21 13:34:17 UTC) #3
Benedikt Meurer
LGTM, thanks.
5 years, 3 months ago (2015-09-21 13:35:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356913002/20001
5 years, 3 months ago (2015-09-21 13:59:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 14:00:55 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 14:01:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c610a22231212b12055c294f55b8f3942127580b
Cr-Commit-Position: refs/heads/master@{#30849}

Powered by Google App Engine
This is Rietveld 408576698