Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013. (Closed)

Created:
5 years, 3 months ago by Ted Mielczarek
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013. The Windows client gyp files were missing proc_maps_linux.cc for the unittest build. Adding that revealed some build errors due to it unconditionally including <inttypes.h>. Removing the workarounds in breakpad_types.h (and a few other places) made that build, which means that Visual C++ 2013 is now our minimum supported version of MSVC. Additionally I tried building with VC++ 2015 and fixed a few warnings (which were failing the build because we have /WX enabled) to ensure that that builds as well. BUG=https://code.google.com/p/google-breakpad/issues/detail?id=669 R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/be849f06377071576eae5aaaf49e033b7a747ea7

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -36 lines) Patch
M src/client/windows/tests/crash_generation_app/crash_generation_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/unittests/client_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/client/windows/unittests/crash_generation_server_test.cc View 1 chunk +1 line, -1 line 2 comments Download
M src/google_breakpad/common/breakpad_types.h View 1 chunk +0 lines, -24 lines 0 comments Download
M src/processor/dump_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/processor/minidump.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/processor/proc_maps_linux.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Ted Mielczarek
Some day I will remember to --send_mail (Wish I could make that the default!)
5 years, 2 months ago (2015-09-29 16:09:45 UTC) #2
Mark Mentovai
LGTM https://codereview.chromium.org/1353893002/diff/1/src/client/windows/unittests/crash_generation_server_test.cc File src/client/windows/unittests/crash_generation_server_test.cc (right): https://codereview.chromium.org/1353893002/diff/1/src/client/windows/unittests/crash_generation_server_test.cc#newcode53 src/client/windows/unittests/crash_generation_server_test.cc:53: size_t kCustomInfoCount = 2; const. Or get rid ...
5 years, 2 months ago (2015-09-29 17:40:20 UTC) #3
Ted Mielczarek
5 years, 2 months ago (2015-10-06 12:04:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be849f06377071576eae5aaaf49e033b7a747ea7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698