src/processor/dump_context.cc - Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/processor/dump_context.cc

Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: src/processor/dump_context.cc

diff --git a/src/processor/dump_context.cc b/src/processor/dump_context.cc

index 612556a2451d13018f9d663d0ef1674ce6f88810..49fb77b15fcade8bc406a1f154298be93d060792 100644

--- a/src/processor/dump_context.cc

+++ b/src/processor/dump_context.cc

@@ -38,9 +38,9 @@

#ifdef _WIN32

#include <io.h>

-#define PRIx64 "llx"

-#define PRIx32 "lx"

+#if defined(_MSC_VER) && _MSC_VER < 1900

#define snprintf _snprintf

+#endif

#else // _WIN32

#include <unistd.h>

#endif // _WIN32

« src/client/windows/unittests/crash_generation_server_test.cc ('K') | « src/google_breakpad/common/breakpad_types.h ('k') | src/processor/minidump.cc » ('j') | no next file with comments »